Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Correlations #1115

Merged
merged 18 commits into from
Jan 28, 2025
Merged

refactor: Correlations #1115

merged 18 commits into from
Jan 28, 2025

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 17, 2025

Fixes #XXXX.

Description

  • Use Deref, enables changing self.0 ~> self.
  • Use HashMap to enable quick retreival.
  • Encapsulate mutations into a single method.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 17, 2025

Pull Request Test Coverage Report for Build 12994526875

Details

  • 0 of 137 (0.0%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 12.753%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/http/correlation.rs 0 29 0.0%
src/correlation.rs 0 108 0.0%
Files with Coverage Reduction New Missed Lines %
src/handlers/http/correlation.rs 1 0.0%
src/correlation.rs 6 0.0%
Totals Coverage Status
Change from base Build 12991591562: 0.02%
Covered Lines: 2443
Relevant Lines: 19157

💛 - Coveralls

@nikhilsinhaparseable
Copy link
Contributor

@de-sh while validating the PR, i found that the id of the correlation is not loaded at the server start but the json has the id.
image
image

can you please check.

Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nitisht nitisht merged commit 12c507c into parseablehq:main Jan 28, 2025
11 checks passed
@de-sh de-sh deleted the correlations branch January 28, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants