-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Adding digital noise #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @chMoussa. Some comments from me but mainly about renaming. Happy to quickly approve after you've addressed them.
Co-authored-by: RolandMacDoland <[email protected]>
Co-authored-by: RolandMacDoland <[email protected]>
Co-authored-by: RolandMacDoland <[email protected]>
Co-authored-by: RolandMacDoland <[email protected]>
Co-authored-by: RolandMacDoland <[email protected]>
Co-authored-by: RolandMacDoland <[email protected]>
Co-authored-by: RolandMacDoland <[email protected]>
Co-authored-by: RolandMacDoland <[email protected]>
Co-authored-by: RolandMacDoland <[email protected]>
Co-authored-by: RolandMacDoland <[email protected]>
Co-authored-by: RolandMacDoland <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @chMoussa. Final and minor comments otherwise LGTM.
Co-authored-by: RolandMacDoland <[email protected]>
Closes #33 by:
NoiseInstance
with differentNoiseType
values from where we can extract the krauss operators.NoiseInstance
apply
functions to handle noise and inputState
provided as a density matrix.api
functions to work with density matrices.sample
andexpectation
as they were redundant with theapi
's