Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adding digital noise #34

Merged
merged 86 commits into from
Jan 8, 2025
Merged

[Feature] Adding digital noise #34

merged 86 commits into from
Jan 8, 2025

Conversation

chMoussa
Copy link
Collaborator

@chMoussa chMoussa commented Dec 4, 2024

Closes #33 by:

  • Adding a NoiseInstance with different NoiseType values from where we can extract the krauss operators.
  • Adding a noise argument to gates as a tuple of NoiseInstance
  • Extending apply functions to handle noise and input State provided as a density matrix.
  • Extending the api functions to work with density matrices.
  • Adding tests
  • Adding section noise in docs
  • Removing circuit methods sample and expectation as they were redundant with the api's

@chMoussa chMoussa self-assigned this Dec 4, 2024
@chMoussa chMoussa requested a review from mlahariya December 30, 2024 09:37
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @chMoussa. Some comments from me but mainly about renaming. Happy to quickly approve after you've addressed them.

docs/noise.md Outdated Show resolved Hide resolved
docs/noise.md Outdated Show resolved Hide resolved
docs/noise.md Outdated Show resolved Hide resolved
docs/noise.md Outdated Show resolved Hide resolved
docs/noise.md Outdated Show resolved Hide resolved
horqrux/utils_noise.py Outdated Show resolved Hide resolved
horqrux/utils_noise.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tests/test_noise.py Outdated Show resolved Hide resolved
tests/test_noise.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @chMoussa. Final and minor comments otherwise LGTM.

horqrux/api.py Show resolved Hide resolved
horqrux/api.py Outdated Show resolved Hide resolved
horqrux/noise.py Show resolved Hide resolved
horqrux/shots.py Show resolved Hide resolved
horqrux/utils.py Outdated Show resolved Hide resolved
horqrux/utils_noise.py Show resolved Hide resolved
@chMoussa chMoussa merged commit 5b1de24 into main Jan 8, 2025
6 checks passed
@chMoussa chMoussa deleted the cm/krauss_ops branch January 8, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add digital noise
3 participants