Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove unnecessary bool return from new functions #110

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

tdeshong
Copy link
Contributor

@tdeshong tdeshong commented Nov 22, 2024

BEGIN_COMMIT_OVERRIDE
chore: remove unnecessary bool return from new functions
END_COMMIT_OVERRIDE

What's New?

The new delete methods will only return error

- Passage.User.Delete(userId: string): error
- Passage.User.RevokeDevice(userId: string, deviceId: string): error
- Passage.RevokeRefreshTokens(userID string) error
   

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@tdeshong tdeshong marked this pull request as ready for review November 22, 2024 18:50
Base automatically changed from PSG-4995-error-test to main November 22, 2024 23:38
@ctran88 ctran88 force-pushed the feat-remove-delete-bool branch from 0c3d256 to 8dcc166 Compare November 22, 2024 23:44
@ctran88 ctran88 changed the title feat: remove bool from deletes feat: remove unnecessary bool return from new functions Nov 22, 2024
@ctran88 ctran88 merged commit be26032 into main Nov 22, 2024
6 checks passed
@ctran88 ctran88 deleted the feat-remove-delete-bool branch November 22, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants