Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Fix nested View All page #102

Closed
wants to merge 1 commit into from

Conversation

novascreen
Copy link

On View All pages like for all Atoms or Molecules the general-footer is missing. The address bar, menu and pattern lab elements on the page break.
I believe this is the commit which broke things: 67c193d
I also think this might be related to pattern-lab/patternlab-php#370 and pattern-lab/styleguidekit-assets-default#41

Sorry for the messup on the previous PR.

@rocketeerbkw
Copy link

This has been fixed in the dev branch for quite awhile, see c976fa4

You'll need to specify that exact commit in your composer.json though because the latest dev is broken, see #87

@froboy
Copy link

froboy commented Feb 24, 2017

In our composer.json I had to do the following to get this through all of the dependencies:

"require": {
  "php": ">=5.4",
  "pattern-lab/core": "dev-dev#c976fa4cbffac7a67c41df43f47899d09a965a49",
  "pattern-lab/patternengine-twig": "dev-dev",
  "pattern-lab/styleguidekit-twig-default": "dev-dev"
},

but then I was able to pull in the correct commit without conflict.

@KatieMFritz
Copy link

Thanks @novascreen for the PR and @frobo for the configuration advice! I was getting errors when I put exactly what @froboy recommended, but after trying a few things, this worked for me:

"require": {
  "php": ">=5.4",
  "pattern-lab/core": "dev-dev#c976fa4cbffac7a67c41df43f47899d09a965a49",
  "pattern-lab/patternengine-twig": "dev-dev",
  "pattern-lab/styleguidekit-twig-default": "^3.0.0"
},

@davejtoews
Copy link

Thanks all. I'm using mustache rather than twig, so I don't know if this would have worked for @KatieMFritz and @froboy. But I just changed one line of composer.json and used the specific commit as an alias for 2.7.0 so that the composer didn't flag conflicting versions of pattern-lab/core.

"pattern-lab/core": "dev-dev#c976fa4cbffac7a67c41df43f47899d09a965a49 as 2.7.0",

@EvanLovely
Copy link
Member

All fixed now as of v2.8.0!!

@EvanLovely EvanLovely closed this Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants