-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First cut at implementing tracking #339
base: main
Are you sure you want to change the base?
Conversation
Preview: https://chatbot-pr-virtual-assistant-339.surge.sh A11y report: https://chatbot-pr-virtual-assistant-339-a11y.surge.sh Preview: https://chatbot-pr-chatbot-339.surge.sh A11y report: https://chatbot-pr-chatbot-339-a11y.surge.sh |
|
||
{ | ||
integrations: { | ||
...props.segmentIntegrations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know what the purpose of this integrations object is? I cannot figure out what values would be expected and valid here.
You can only use ...
before a variable or object if it is actually an iterable type like an array or json object. if it's a primitive like a string, then you cannot use the ...
spreading operator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be a json object.
This would be an example of the InitProps
:
segmentIntegrations: {
'Segment.io': {
apiHost: 'my.proxy.host/connections/api/v1',
protocol: 'https'
}
},
So the 'Segment.io' part is filled in by the ...props.segmentIntegrations
.
Add Analytics tracking code with documentation.