Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First cut at implementing tracking #339

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

pilhuhn
Copy link
Collaborator

@pilhuhn pilhuhn commented Nov 26, 2024

Add Analytics tracking code with documentation.

@pilhuhn pilhuhn marked this pull request as ready for review January 24, 2025 17:00
@nicolethoen nicolethoen self-requested a review January 30, 2025 15:13

{
integrations: {
...props.segmentIntegrations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what the purpose of this integrations object is? I cannot figure out what values would be expected and valid here.

You can only use ... before a variable or object if it is actually an iterable type like an array or json object. if it's a primitive like a string, then you cannot use the ... spreading operator.

Copy link
Collaborator Author

@pilhuhn pilhuhn Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a json object.

This would be an example of the InitProps:

segmentIntegrations: {
         'Segment.io': {
           apiHost: 'my.proxy.host/connections/api/v1',
           protocol: 'https'
         }
       },

So the 'Segment.io' part is filled in by the ...props.segmentIntegrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spike - Create POC of API / Demo for wiring up user analytics
3 participants