Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): Add CLI for scss build with option for custom selector #35

Merged
merged 7 commits into from
May 1, 2024

Conversation

wise-king-sullyman
Copy link
Contributor

@wise-king-sullyman wise-king-sullyman commented Apr 17, 2024

Closes #9

The changes to build.js look significant, but the only real change I made with it was changing it to a function that's exported rather than it just being a script file that runs.

By default yarn build:scss still outputs the same content with :root as the selector, but now you can also pass the --selector flag (or just -s for short) and specify any selector you want, i.e. yarn build:scss -s .foo will replace the :root selector with .foo in the generated scss files.

Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to the readme please?

Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Works great with yarn build:scss -s '@mixin pf-v6-tokens' 🎖️

@srambach srambach merged commit 2964662 into main May 1, 2024
3 checks passed
Copy link

github-actions bot commented May 1, 2024

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export css variables without a selector
2 participants