Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(animation): export and transform animation tokens #48

Merged
merged 1 commit into from
May 9, 2024

Conversation

srambach
Copy link
Member

@srambach srambach commented May 8, 2024

Fixes #30
This extends the exporter to handle the animation tokens collection.
It also adds a custom exporter to transform duration and delay values to ms.
This PR also updates some documentation.

Note that this PR doesn't actually add the animation tokens because they are still being finalized in a Figma branch.

Comment on lines +8 to +10
1. Open the Figma app.
1. In Figma, select **Plugins** > **Development** > **Import plugin from manifest**.
1. Browse to **design-tokens\packages\module\plugins\export-patternfly-tokens** and select the **manifest.json** file from your cloned design-tokens repository and click **Open**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 love the markdown change

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPTM! 🥸

@srambach srambach merged commit e9d7eaa into patternfly:main May 9, 2024
3 checks passed
Copy link

github-actions bot commented May 9, 2024

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporter - test the export of animation tokens
4 participants