-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tokens): import change of cyan/gold to teal/yellow #63
Conversation
@lboehling after exporting from figma, I'm still seeing these cyan/gold tokens generated - looks like the nonstatus "base" colors are still referencing the old name? The left side is the file name and right side is the token declaration that contains "cyan" or "gold".
Not sure if this is the right place in figma, but confirmed the nonstatus base tokens look like they're still referencing cyan/gold here |
@mcoker fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!! 🌈
@lboehling the way the font-family names are defined in the figma tokens are a bit different from the way they're defined in core. The difference is just that there are spaces in the name in figma, and in core there are no spaces:
It's really easy to fix core if the tokens in figma need the spaces, but wanted to check and see first if they need to be defined that way or if we could define them with no spaces? |
@mcoker yeah, if that's an easy fix, can we fix core? Figma automatically adds those spaces when the font files are pulled in, so I had to match the spaces in the string variable for it to match! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closing, we'll run a new export to pick up any add'l changes. |
fixes #62