Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tokens): import change of cyan/gold to teal/yellow #63

Closed
wants to merge 1 commit into from

Conversation

mcoker
Copy link
Contributor

@mcoker mcoker commented Jun 4, 2024

fixes #62

@mcoker mcoker requested review from srambach and lboehling June 4, 2024 22:07
@mcoker
Copy link
Contributor Author

mcoker commented Jun 4, 2024

@lboehling after exporting from figma, I'm still seeing these cyan/gold tokens generated - looks like the nonstatus "base" colors are still referencing the old name? The left side is the file name and right side is the token declaration that contains "cyan" or "gold".

tokens-dark.scss:  --pf-t--global--dark--color--nonstatus--cyan--300: var(--pf-t--color--teal--10);
tokens-dark.scss:  --pf-t--global--dark--color--nonstatus--cyan--200: var(--pf-t--color--teal--20);
tokens-dark.scss:  --pf-t--global--dark--color--nonstatus--cyan--100: var(--pf-t--color--teal--30);
tokens-dark.scss:  --pf-t--global--dark--color--nonstatus--gold--300: var(--pf-t--color--yellow--10);
tokens-dark.scss:  --pf-t--global--dark--color--nonstatus--gold--200: var(--pf-t--color--yellow--20);
tokens-dark.scss:  --pf-t--global--dark--color--nonstatus--gold--100: var(--pf-t--color--yellow--30);
tokens-dark.scss:  --pf-t--global--border--color--nonstatus--teal--clicked: var(--pf-t--global--dark--color--nonstatus--cyan--200);
tokens-dark.scss:  --pf-t--global--border--color--nonstatus--teal--hover: var(--pf-t--global--dark--color--nonstatus--cyan--200);
tokens-dark.scss:  --pf-t--global--border--color--nonstatus--teal--default: var(--pf-t--global--dark--color--nonstatus--cyan--100);
tokens-dark.scss:  --pf-t--global--border--color--nonstatus--yellow--clicked: var(--pf-t--global--dark--color--nonstatus--gold--200);
tokens-dark.scss:  --pf-t--global--border--color--nonstatus--yellow--hover: var(--pf-t--global--dark--color--nonstatus--gold--200);
tokens-dark.scss:  --pf-t--global--border--color--nonstatus--yellow--default: var(--pf-t--global--dark--color--nonstatus--gold--100);
tokens-dark.scss:  --pf-t--global--color--nonstatus--teal--clicked: var(--pf-t--global--dark--color--nonstatus--cyan--200);
tokens-dark.scss:  --pf-t--global--color--nonstatus--teal--hover: var(--pf-t--global--dark--color--nonstatus--cyan--200);
tokens-dark.scss:  --pf-t--global--color--nonstatus--teal--default: var(--pf-t--global--dark--color--nonstatus--cyan--100);
tokens-dark.scss:  --pf-t--global--color--nonstatus--yellow--clicked: var(--pf-t--global--dark--color--nonstatus--gold--200);
tokens-dark.scss:  --pf-t--global--color--nonstatus--yellow--hover: var(--pf-t--global--dark--color--nonstatus--gold--200);
tokens-dark.scss:  --pf-t--global--color--nonstatus--yellow--default: var(--pf-t--global--dark--color--nonstatus--gold--100);
tokens-default.scss:  --pf-t--global--color--nonstatus--cyan--300: var(--pf-t--color--teal--40);
tokens-default.scss:  --pf-t--global--color--nonstatus--cyan--200: var(--pf-t--color--teal--30);
tokens-default.scss:  --pf-t--global--color--nonstatus--cyan--100: var(--pf-t--color--teal--20);
tokens-default.scss:  --pf-t--global--color--nonstatus--gold--300: var(--pf-t--color--yellow--40);
tokens-default.scss:  --pf-t--global--color--nonstatus--gold--200: var(--pf-t--color--yellow--30);
tokens-default.scss:  --pf-t--global--color--nonstatus--gold--100: var(--pf-t--color--yellow--20);
tokens-default.scss:  --pf-t--global--color--nonstatus--teal--clicked: var(--pf-t--global--color--nonstatus--cyan--200);
tokens-default.scss:  --pf-t--global--color--nonstatus--teal--hover: var(--pf-t--global--color--nonstatus--cyan--200);
tokens-default.scss:  --pf-t--global--color--nonstatus--teal--default: var(--pf-t--global--color--nonstatus--cyan--100);
tokens-default.scss:  --pf-t--global--color--nonstatus--yellow--clicked: var(--pf-t--global--color--nonstatus--gold--200);
tokens-default.scss:  --pf-t--global--color--nonstatus--yellow--hover: var(--pf-t--global--color--nonstatus--gold--200);
tokens-default.scss:  --pf-t--global--color--nonstatus--yellow--default: var(--pf-t--global--color--nonstatus--gold--100);
tokens-default.scss:  --pf-t--global--border--color--nonstatus--teal--clicked: var(--pf-t--global--color--nonstatus--cyan--300);
tokens-default.scss:  --pf-t--global--border--color--nonstatus--teal--hover: var(--pf-t--global--color--nonstatus--cyan--300);
tokens-default.scss:  --pf-t--global--border--color--nonstatus--teal--default: var(--pf-t--global--color--nonstatus--cyan--200);
tokens-default.scss:  --pf-t--global--border--color--nonstatus--yellow--clicked: var(--pf-t--global--color--nonstatus--gold--300);
tokens-default.scss:  --pf-t--global--border--color--nonstatus--yellow--hover: var(--pf-t--global--color--nonstatus--gold--300);
tokens-default.scss:  --pf-t--global--border--color--nonstatus--yellow--default: var(--pf-t--global--color--nonstatus--gold--200);

Not sure if this is the right place in figma, but confirmed the nonstatus base tokens look like they're still referencing cyan/gold here

Screenshot 2024-06-04 at 5 37 30 PM

@lboehling
Copy link

@mcoker fixed!

Copy link

@lboehling lboehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!! 🌈

@mcoker
Copy link
Contributor Author

mcoker commented Jun 13, 2024

@lboehling the way the font-family names are defined in the figma tokens are a bit different from the way they're defined in core. The difference is just that there are spaces in the name in figma, and in core there are no spaces:

  • Figma - "Red Hat [Text/Display/Mono] VF"
  • Core - "redhat[text/display/mono]vf"

It's really easy to fix core if the tokens in figma need the spaces, but wanted to check and see first if they need to be defined that way or if we could define them with no spaces?

@lboehling
Copy link

@mcoker yeah, if that's an easy fix, can we fix core? Figma automatically adds those spaces when the font files are pulled in, so I had to match the spaces in the string variable for it to match!

Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcoker
Copy link
Contributor Author

mcoker commented Jun 20, 2024

Closing, we'll run a new export to pick up any add'l changes.

@mcoker mcoker closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import rename of cyan/gold tokens to teal/yellow
3 participants