Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(export): add export all files to zip #67

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

evwilkin
Copy link
Member

@evwilkin evwilkin commented Jun 7, 2024

Closes #22

This PR:

  • Adds a new download file tokens.zip which unzips to include the full tokens directory with dark and default subdirectories & all included files.
  • Adds webpack && typescript to the plugin workflow.

Plugin source code now lives in plugins/export-patternfly-tokens/src and compiles to plugins/export-patternfly-tokens/dist, which is the final code used by Figma, by running yarn build:plugin.

Prior individual JSON file download links are unchanged. Note that plugins dist directory has been committed to allow for plug-and-play for designers rather than having to compile code, but I'm open to alternate suggestions.

@evwilkin evwilkin marked this pull request as ready for review June 11, 2024 15:29
@srambach
Copy link
Member

@evwilkin has the process changed enough for the readme to be updated?

@evwilkin
Copy link
Member Author

@srambach yes thanks for the catch, I'll update the README 👍

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out, works like a charm!

@srambach srambach merged commit e13067b into patternfly:main Jun 21, 2024
3 checks passed
Copy link

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporter - save files as zip
3 participants