fix: bump extension docs to v6 #4344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed the log viewer extension has an option to toggle dark mode. |
|
I will open a follow up issue with the log-viewer. The dark theme should be able be enabled even when the rest of the app is in light theme. It's probably an issue with how the tokens were updated. |
nicolethoen
force-pushed
the
bump_exts_6
branch
2 times, most recently
from
9763350 to
fe019c5
Compare
|
@nicolethoen User feedback modals are behaving oddly (appending to the page / not being on top) |
|
I'll open a bug for user-feedback. That was not introduced with this PR. It's already broken on staging. |
|
Bug fix issue for user feedback: patternfly/react-user-feedback#85 |
nicolethoen
force-pushed
the
bump_exts_6
branch
from
fe019c5 to
bb67c05
Compare
nicolethoen
force-pushed
the
bump_exts_6
branch
from
bb67c05 to
e5f0ab2
Compare
dlabaj
approved these changes
Oct 29, 2024
kmcfaul
reviewed
Oct 29, 2024
| "@patternfly/quickstarts": "6.0.0", | ||
| "@patternfly/react-virtualized-extension": "6.0.0", | ||
| "@patternfly/react-templates": "6.0.0", | ||
| "@patternfly/virtual-assistant": "2.0.0" | ||
| } | ||
| },{ | ||
| "name": "prerelease", |
There was a problem hiding this comment.
Couple lines down can we flip the prerelease both to hidden? Or remove it.
kmcfaul
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.