fix(tree): Avoid casting the props

patternfly · Sep 11, 2024 · a7db24b · a7db24b
1 parent a3b5b7f
commit a7db24b
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/packages/module/src/DataViewTable/DataViewTable.tsx b/packages/module/src/DataViewTable/DataViewTable.tsx
@@ -22,10 +22,16 @@ export const isDataViewTrObject = (value: DataViewTr): value is { row: DataViewT
 // Tree table typings
 export interface DataViewTrTree extends DataViewTrObject { id: string, children?: DataViewTrTree[] }
 
-export type DataViewTableProps = DataViewTableBasicProps | DataViewTableTreeProps;
+export type DataViewTableProps =
+  | ({
+      isTreeTable: true;
+    } & DataViewTableTreeProps)
+  | ({
+      isTreeTable?: false;
+    } & DataViewTableBasicProps);
 
-export const DataViewTable: React.FC<DataViewTableProps> = ({ isTreeTable, ...props }: DataViewTableProps) => (
-  isTreeTable ? (<DataViewTableTree {...(props as DataViewTableTreeProps)} />) : (<DataViewTableBasic {...(props as DataViewTableBasicProps)}/>)
+export const DataViewTable: React.FC<DataViewTableProps> = (props) => (
+  props.isTreeTable ? <DataViewTableTree {...props} /> : <DataViewTableBasic {...props} />
 );
 
 export default DataViewTable;