Enhance useDataViewPagination with URL persisting #16
Conversation
BREAKING CHANGE: let's see...
packages/module/release.config.js
Outdated
| @@ -10,5 +14,5 @@ module.exports = { | |||
| '@semantic-release/npm' | |||
| ], | |||
| tagFormat: 'prerelease-v${version}', | |||
| dryRun: false | |||
| dryRun: true | |||
There was a problem hiding this comment.
It's not, thank you
| result.current.onSetPage(undefined, 4); | ||
| }); | ||
|
|
||
| expect(mockSetSearchParams).toHaveBeenCalledTimes(2); |
There was a problem hiding this comment.
You check if the setter was called but not what values were passed to the argument.
There was a problem hiding this comment.
Oh yeah I forgot to finish this one
| updated && setSearchParams(params); | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, []); |
There was a problem hiding this comment.
I assume we are deliberately ignoring the changes in the inputs? But what if the URL changes by other means that just through the hook? Should the component react? Maybe the query values themselves should be in the dependency array.
| setSearchParams, | ||
| }: UseDataViewPaginationProps) => { | ||
| const [ state, setState ] = useState({ | ||
| page: searchParams?.get('page') !== null |
There was a problem hiding this comment.
I think you want some enum or constants for the query param names. Just so you don't have string around the code which might get tricky to update at some point.
|
🎉 This PR is included in version 7.0.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
RHCLOUD-34819
Enhanced useDataViewPagination hook with URL persisting and rebased to the latest main