Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add selection to DataView #9

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Add selection to DataView #9

merged 4 commits into from
Jun 21, 2024

Conversation

fhlavac
Copy link
Collaborator

@fhlavac fhlavac commented Jun 18, 2024 •
edited
Loading

RHCLOUD-32251

image

  • added selection to DataView using the BulkSelect from component-groups
  • enhanced and reorganized the docs and examples
  • added test coverage

@patternfly-build
Copy link

patternfly-build commented Jun 18, 2024 •
edited
Loading

Preview: https://react-data-view-pr-data-view-9.surge.sh

A11y report: https://react-data-view-pr-data-view-9-a11y.surge.sh

@fhlavac fhlavac marked this pull request as ready for review June 19, 2024 11:03
@fhlavac fhlavac force-pushed the selection branch 2 times, most recently from bb7ffb8 to f278012 Compare June 19, 2024 12:42
@fhlavac fhlavac merged commit 0973672 into patternfly:main Jun 21, 2024
7 checks passed
@fhlavac fhlavac deleted the selection branch June 21, 2024 14:10
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0-prerelease.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelhala karelhala karelhala approved these changes

@dlabaj dlabaj Awaiting requested review from dlabaj

@Hyperkid123 Hyperkid123 Awaiting requested review from Hyperkid123

@andrew-ronaldson andrew-ronaldson Awaiting requested review from andrew-ronaldson

Assignees
No one assigned
Labels
released on @prerelease released on @prerelease-v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fhlavac @patternfly-build @karelhala