-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV: switch to using subscription gem to avoid the need to rely on Subscription Client plugin #266
Conversation
merefield
commented
Sep 8, 2023
•
edited
Loading
edited
- IMPROVE: moves CW to rely on referenced gem instead of Subscription Client, so it can run entirely independently.
- IMPROVE: rationalises and consolidates subscription logic somewhat:
- COMPATIBILITY: moves FE subscriptions management to a Service (in part because Mixins are deprecated)
- IMPROVE: moves subscription serialisation to a dedicated controller on the BE.
- COMPATIBILITY: converts several related Components to Glimmer (and colocates template files as per standard).
- alters the way subscription client is mocked up in tests to accommodate the fact that overriding the class does not work the same way now that we've added the gem
- adds FE tests for Authorization and Subscription status.
- COMPATIBILITY: fixes deprecation of registerUnbound with Wizard Char Counter
- FIX: non working FE tests because of refactor of Core Composer has changed CSS selectors.
- IMPROVE: moves Pavilion icon to standard SVG registration system (from ad hoc template addition).
…se-custom-wizard into use_subscription_gem
@angusmcleod, these front end tests are not failing locally on two types of browser, any ideas? Otherwise this should be hot to trot. |
Not sure. @jumagura Any idea why these tests are failing? |
@jumagura please ignore, I found the problem, it's a breaking change from core due to updates to Composer and Modal selectors. This is currently also breaking Production tests, but I've fixed it here. @angusmcleod this is now ready for review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@merefield Two minor changes and a comment for future reference (no need to convert to .gjs in this PR).
assets/javascripts/discourse/components/wizard-subscription-badge.hbs
Outdated
Show resolved
Hide resolved
both requested changes implemented @angusmcleod ... |
@merefield Looks like we've got a failing check here. |
resolved @angusmcleod |