-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: If RSS is enabled, show RSS icon in menu #63
base: master
Are you sure you want to change the base?
Changes from all commits
b69654d
3d03d06
c5f29a6
ec0b182
2bb4eb9
6c8a4b3
640d3fe
5017bf6
8fc4001
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
The MIT License (MIT) | ||
|
||
Copyright (c) 2013-2023 Cole Bemis | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy | ||
of this software and associated documentation files (the "Software"), to deal | ||
in the Software without restriction, including without limitation the rights | ||
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
copies of the Software, and to permit persons to whom the Software is | ||
furnished to do so, subject to the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be included in all | ||
copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
SOFTWARE. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -348,6 +348,41 @@ page_titles = "combined" | |
All the configuration options are also described in | ||
[`config.toml`](../master/config.toml). | ||
|
||
|
||
### RSS | ||
|
||
This theme supports RSS feeds. | ||
To enable RSS you need to set those 3 configuration settings to valid values: | ||
|
||
```toml | ||
generate_feeds = true | ||
author = "[email protected]" | ||
|
||
# Use `rss.xml` for RSS feeds and `atom.xml` for ATOM. | ||
feed_filenames = ["rss.xml", "atom.xml"] | ||
``` | ||
|
||
Note that `author` is also required as part of the RSS spec. | ||
You can read more on https://www.getzola.org/documentation/templates/feeds/ about the potential values, since RFC 4287 requires author to be a name and not an email. | ||
|
||
To add an RSS icon to the main menu, you can add this entry to the `menu_items` : | ||
|
||
```toml | ||
menu_items = [ | ||
# RSS | ||
{name = "", url = "$BASE_URL/$FEED_FILENAME"} | ||
] | ||
``` | ||
|
||
You can also customize the color of the RSS icon by changing the `rss_icon_color`: | ||
|
||
```toml | ||
[extra] | ||
|
||
# ... | ||
rss_icon_color = "#ee802f" | ||
``` | ||
|
||
## Extending | ||
|
||
Each of the templates defines named blocks, so | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,11 +38,45 @@ | |
<ul class="menu__inner"> | ||
{%- for item in menu_items %} | ||
<li {%- if current_item and current_item == item %} class="active" {%- endif %}> | ||
{%- if item.newtab -%} | ||
<a href="{{ item.url | replace(from="$BASE_URL", to=config.base_url) | safe }}" target="_blank" rel="noopener noreferrer">{{ item.name | safe }}</a> | ||
|
||
<!-- RSS --> | ||
{%- set is_rss = item.url == "$BASE_URL/$FEED_FILENAME" -%} | ||
|
||
{%- if config.extra.rss_icon_color %} | ||
{%- set rss_icon_color = config.extra.rss_icon_color %} | ||
{%- else %} | ||
{%- set rss_icon_color = "#ee802f" %} | ||
{%- endif %} | ||
|
||
{%- if is_rss -%} | ||
{%- if config.generate_feeds %} | ||
{%- for feed in config.feed_filenames %} | ||
{%- if feed is containing('rss') %} | ||
<a rel="alternate" type="application/rss+xml" title="RSS Feed" href="{{ get_url(path=feed, trailing_slash=false, lang=lang) | safe }}" /> | ||
{% endif -%} | ||
{%- if feed is containing('atom') %} | ||
<a rel="alternate" type="application/atom+xml" title="ATOM Feed" href="{{ get_url(path=feed, trailing_slash=false, lang=lang) | safe }}" /> | ||
{% endif -%} | ||
{% endfor -%} | ||
|
||
<svg id="rss-icon" xmlns="http://www.w3.org/2000/svg" width="22" height="22" viewBox="0 0 32 32" fill="none" stroke="{{rss_icon_color}}" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="feather feather-rss"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should give credit to feather icons https://feathericons.com/ and include their LICENSE file in the repo https://github.com/feathericons/feather/blob/main/LICENSE as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added in 5017bf6 |
||
<g transform="translate(0,5)"> | ||
<path d="M4 11a9 9 0 0 1 9 9"></path> | ||
<path d="M4 4a16 16 0 0 1 16 16"></path> | ||
<circle cx="5" cy="19" r="1"></circle> | ||
</g> | ||
</svg> | ||
</a> | ||
{% endif -%} | ||
|
||
{%- else -%} | ||
<a href="{{ item.url | replace(from="$BASE_URL", to=config.base_url) | safe }}">{{ item.name | safe }}</a> | ||
{%- if item.newtab -%} | ||
<a href="{{ item.url | replace(from="$BASE_URL", to=config.base_url) | safe }}" target="_blank" rel="noopener noreferrer">{{ item.name | safe }}</a> | ||
{%- else -%} | ||
<a href="{{ item.url | replace(from="$BASE_URL", to=config.base_url) | safe }}">{{ item.name | safe }}</a> | ||
{%- endif -%} | ||
{%- endif -%} | ||
|
||
</li> | ||
{% endfor -%} | ||
</ul> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use
{%- if feed is containing('rss') %}
elsewhere now (see #71), would be good to keep it consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To do that, I'd need to do it inside the
{%- for feed in config.feed_filenames %}
loop, but this specific if is guarding against a different thing: whether or not the current item refers to the RSS icon or not (we don't care about RSS or ATOM at this stage). If it is referring to RSS, then we can add the svg icon and also add the relevant<a>
element depending if it's ATOM or RSS. Does that make sense ?