fix(ui): remove clearData call in dropzone drop handler #10475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes an issue for Firefox users where dropping files over a dropzone component caused a
NoModificationAllowedError: Modifications are not allowed for this document
due to the usage of thedataTransfer.clearData
function.As per MDN docs, the
clearData
function does not remove files from drag operations anyway, and can only be used in the context of adragStart
event.Why?
To prevent a runtime error encountered while dropping files over dropzones.
How?
By removing the call to
clearData
in thehandleDrop
of theDropzone
component.Notes:
clearData
shouldn't have an impact outside of removing the error as the call was somewhat redundant in that it does not affect files. In my testing, theDropzone
andBulkUpload
components behave as expected.OffscreenCanvas
causes an error when handlingsvg
files while creating thumbnails. This is used in theBulkUpload
drawersFileManager
. I'll investigate this further and create an appropriate issue, and hopefully a PR for this.Fixes #10472