Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to other worker type in log prefix #247

Merged
merged 1 commit into from
May 3, 2022

Conversation

shtiencode
Copy link
Collaborator

@shtiencode shtiencode commented Apr 29, 2022

fix the issue #65 so worker other than regular types can connect to db successfully

@shtiencode shtiencode requested a review from venkatsridhar95 May 2, 2022 16:18
Copy link
Collaborator

@venkatsridhar95 venkatsridhar95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should address #65 when both workers are pointing to the same DB. There needs to be an adjustment in the heartbeat checks if the workers are pointing to different nodes in a master-slave kind of a setup.

@venkatsridhar95 venkatsridhar95 merged commit 5ba6ff5 into paypal:master May 3, 2022
@shtiencode shtiencode deleted the pub_master branch May 16, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants