create new types for createOrder and creatVaultToken #605
Conversation
🦋 Changeset detectedLatest commit: 35591cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
||
| export interface PayPalCardFieldsComponentCreateVaultSetupToken | ||
| extends PayPalCardFieldsComponentBasics { | ||
| createOrder?: never; |
There was a problem hiding this comment.
lets revisit if we need createOrder?: never;
There was a problem hiding this comment.
I am not sure if createOrder?: never add any value, so i feel like we can remove that
There was a problem hiding this comment.
There might be value in future clarity.
|
@hnguyen510 can you also add |
| expect(createVaultSetupTokenCallback.createOrder).toBeUndefined(); | ||
| }); | ||
|
|
||
| test.skip("Can't have both", () => { |
There was a problem hiding this comment.
Are these test still supposed to be skipped?
There was a problem hiding this comment.
It still need to be skip right now because there is assertionError. Not sure what assertion call I should do instead.
|
|
||
| export interface PayPalCardFieldsComponentCreateVaultSetupToken | ||
| extends PayPalCardFieldsComponentBasics { | ||
| createOrder?: never; |
There was a problem hiding this comment.
There might be value in future clarity.
.changeset/silly-bears-boil.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@paypal/paypal-js": major | |||
There was a problem hiding this comment.
this is probably a minor change since its not breaking any existing usage of the sdk
There was a problem hiding this comment.
I updated the changeset, how do i remove the old one?
This pr is to fix this LI-73058
Problem: the createOrder callback is require when createVaultToken is implement when it should be one or the other and not both.
Closes #587
Closes #580