Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.11.x improvements : Admin/Account panels, tables and minor fixes #119

Merged
merged 6 commits into from
Feb 23, 2021

Conversation

TBG-FR
Copy link
Contributor

@TBG-FR TBG-FR commented Feb 22, 2021

As said in the title, I highly improved Admin/Account panels look in Dark Theme (sidebars, backgrounds, etc), and did some other minor modifications, especially on tables.

Enjoy ;)

@brunobertoldi
Copy link
Contributor

Admin and Account look great!

@fdellwing
Copy link
Contributor

Admin looks really good 👍

@pbaity
Copy link
Owner

pbaity commented Feb 23, 2021

Looks great! Merging.

@pbaity pbaity merged commit 9151f5d into pbaity:master Feb 23, 2021
@pbaity
Copy link
Owner

pbaity commented Feb 23, 2021

I've mentioned this several times elsewhere, but just to be consistent, a warning that rules that apply to class names like .rcx-css-dlop43 (generated classes) are highly likely to break at the next release (and may already not work for anyone using a different version). Of course we still want the short-term fix, but if there's ever a way to target the same elements via more stable parent or sibling classes, that would be more future-proof.

@fdellwing
Copy link
Contributor

The problem is, that most classes are very general and since RC is full of very specific rules that target generated classes it is hard to get even more specific rules without using the generated classes.

@pbaity
Copy link
Owner

pbaity commented Feb 23, 2021

If there was an emoji on GitHub for "bullseye" I'd react with that instead. I hope in the future that Rocket.Chat will make custom styling easier - it's gotten more difficult over time, not better. Or, of course, they're welcome to introduce a native dark mode anytime now - nothing would make me happier than to retire this repo and declare mission accomplished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants