Skip to content

Commit

Permalink
♻️ Upgrade to Node.js Version 20 (#94)
Browse files Browse the repository at this point in the history
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
  • Loading branch information
pcaversaccio authored Dec 18, 2023
1 parent 7bb3966 commit 4aa0f84
Show file tree
Hide file tree
Showing 9 changed files with 145 additions and 126 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
os:
- ubuntu-latest
node_version:
- 18
- 20

steps:
- name: Checkout
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-contracts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
os:
- ubuntu-latest
node_version:
- 18
- 20

steps:
- name: Checkout
Expand Down Expand Up @@ -92,7 +92,7 @@ jobs:
os:
- ubuntu-latest
node_version:
- 18
- 20

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

## Installation

It is recommended to install [`pnpm`](https://pnpm.io) through the `npm` package manager, which comes bundled with [Node.js](https://nodejs.org/en) when you install it on your system. It is recommended to use a Node.js version `>= 18.0.0`.
It is recommended to install [`pnpm`](https://pnpm.io) through the `npm` package manager, which comes bundled with [Node.js](https://nodejs.org/en) when you install it on your system. It is recommended to use a Node.js version `>= 20.0.0`.

Once you have `npm` installed, you can run the following both to install and upgrade `pnpm`:

Expand Down
2 changes: 1 addition & 1 deletion contracts/lib/forge-std
Submodule forge-std updated 1 files
+1 −1 package.json
9 changes: 8 additions & 1 deletion deploy/deploy-zksync.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ import { HardhatRuntimeEnvironment } from "hardhat/types";
import { Wallet } from "zksync-ethers";
import { Deployer } from "@matterlabs/hardhat-zksync-deploy";

// Colour codes for terminal prints
const RESET = "\x1b[0m";
const GREEN = "\x1b[32m";

function delay(ms: number) {
return new Promise((resolve) => setTimeout(resolve, ms));
}
Expand Down Expand Up @@ -33,8 +37,11 @@ export default async function main(hre: HardhatRuntimeEnvironment) {
await contract.waitForDeployment();
const contractAddress = await contract.getAddress();

console.log("Greeter deployed to:", contractAddress);
console.log("Greeter deployed to: " + `${GREEN}${contractAddress}${RESET}\n`);

console.log(
"Waiting 30 seconds before beginning the contract verification to allow the block explorer to index the contract...\n",
);
await delay(30000); // Wait for 30 seconds before verifying the contract

await hre.run("verify:verify", {
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@
"lint:fix": "pnpm prettier:fix && pnpm solhint:fix && npx eslint **/*.{js,ts} --fix"
},
"devDependencies": {
"@matterlabs/hardhat-zksync-deploy": "^1.1.0",
"@matterlabs/hardhat-zksync-deploy": "^1.1.1",
"@matterlabs/hardhat-zksync-ethers": "0.0.1-beta.1",
"@matterlabs/hardhat-zksync-solc": "^1.0.3",
"@matterlabs/hardhat-zksync-solc": "^1.0.5",
"@matterlabs/hardhat-zksync-verify": "^1.2.1",
"@nomicfoundation/hardhat-chai-matchers": "^2.0.2",
"@nomicfoundation/hardhat-ethers": "^3.0.5",
Expand All @@ -135,11 +135,11 @@
"@typechain/hardhat": "^9.1.0",
"@types/chai": "^4.3.11",
"@types/mocha": "^10.0.6",
"@types/node": "^20.10.4",
"@types/node": "^20.10.5",
"@typescript-eslint/eslint-plugin": "^6.14.0",
"@typescript-eslint/parser": "^6.14.0",
"chai": "^4.3.10",
"eslint": "^8.55.0",
"eslint": "^8.56.0",
"eslint-config-prettier": "^9.1.0",
"ethers": "^6.9.0",
"hardhat": "^2.19.2",
Expand Down
Loading

0 comments on commit 4aa0f84

Please sign in to comment.