Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1205276344521090 internal bridge rbac #167

Merged
merged 53 commits into from
Feb 19, 2024
Merged

Feature/1205276344521090 internal bridge rbac #167

merged 53 commits into from
Feb 19, 2024

Conversation

talhadaar
Copy link
Member

@talhadaar talhadaar commented Nov 27, 2023 •
edited
Loading

Creating this PR for discussion.

TODO need to sync feature branch with parachain_dev after dependency updates.

neutrinoks
neutrinoks approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@neutrinoks neutrinoks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok from my side, but may you consider to replace the RBAC-ID-Type by the pre-defined datatype in our peaq-primitives-xcm. I wrote the URL on that one comment...

precompiles/peaq-rbac/src/selectors.rs Show resolved Hide resolved
@talhadaar
WIP: rbac precimpile scaffolding
a736003
@talhadaar
Initial draft
097af3a
@talhadaar
Added more entrypoints to rbac precompile
474d881
@talhadaar
cargo clippy and fmt fixes
0cb7494
@talhadaar
fix type in rbac.sol
e037c74
@talhadaar
fix type in rbac.sol
6137be0
@talhadaar
Fixed rbac.sol:- fix precompile address and added event
c088933
@talhadaar
change address to bytes32 in rbac.sol
bc52733
@talhadaar
small improvements
7a9f30e
@talhadaar
WIP: further implementations on rbac bridge
91e0aa3
@talhadaar
fix selector log in rbac precompile
4026a2c
@talhadaar
Further implementations on rbac precompile
7923e72
@talhadaar
updated rbac.sol
55cfda2
@talhadaar
Minor fix to rbac.sol
70be315
@talhadaar
Further impmenentations on RBAC precompile
34deb57
@talhadaar
Further implementations on RBAC precompile
f9b72a1
@talhadaar
bug fix: remove precompie::view from state changing functions
cb63f41
@talhadaar
Additional implementations on rbac precompile
843a782
@talhadaar
update rbac.sol
e8ba88a
@talhadaar
Some bug fixes and additional implementations
75967ed
@talhadaar
Some renaming and restructuring
e6aea51
@talhadaar
minor bug and import fixes
25cdacd
@talhadaar
Further implementations on rbac precompile and bugfixes
1906167
@talhadaar
Updated rbac.sol
3481a23
@talhadaar
Further implementations on rbac precompile
1983ec6
@talhadaar
Added all rbac entrypoints to rbac precompile
07ec825
@talhadaar
Implemented rbac.sol totally
c38ff48
@talhadaar talhadaar force-pushed the feature/1205276344521090_internal-bridge-rbac branch from 9102c5c to 51716f0 Compare December 20, 2023 07:31
sfffaaa
sfffaaa reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@sfffaaa sfffaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the All checks have failed

@talhadaar talhadaar self-assigned this Jan 23, 2024
@talhadaar talhadaar added the enhancement New feature or request label Jan 23, 2024
@talhadaar talhadaar merged commit f12e3be into dev Feb 19, 2024
1 check passed
@talhadaar talhadaar deleted the feature/1205276344521090_internal-bridge-rbac branch February 19, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfffaaa sfffaaa sfffaaa approved these changes

@neutrinoks neutrinoks neutrinoks approved these changes

Assignees

@talhadaar talhadaar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@talhadaar @sfffaaa @neutrinoks