Simplified customizations on padding / itemPadding / corners for the main container / activeOpacity / shadows #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elevationShadow customization padding and itemPadding customization use activeBackgroundColor instead of opacity modifier
pedromassango
requested changes
Jun 22, 2021
lib/bottom_navy_bar.dart
Outdated
Comment on lines
21
to
24
| this.corner = const BorderRadius.only( | ||
| topLeft: Radius.circular(0), | ||
| topRight: Radius.circular(0), | ||
| ), |
There was a problem hiding this comment.
Maybe just BorderRadius.zero here!
| final EdgeInsets padding; | ||
|
|
||
| /// Defines padding for the item in a container, defaults to EdgeInsets.symmetric(vertical: 10, horizontal: 4) | ||
| final EdgeInsets itemPadding; |
There was a problem hiding this comment.
Comments must end with a period!
Comment on lines
-170
to
+209
| padding: EdgeInsets.symmetric(horizontal: 4), | ||
| padding: itemPadding, |
There was a problem hiding this comment.
We need to make sure to not break any UI with those changes. So far, removing the horizontal padding may break some existing users
There was a problem hiding this comment.
I'll change the defaults for itemPadding to be EdgeInsets.symmetric(horizontal: 4), that way it won't break anyone's apps
|
Please make sure to include some tests as well, to make sure those features does not break in the future. |
…ner param initialization
…s together in source code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with that it is easy to change per project needs: