Updated and heavily simplified anonymization script #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #235 +/- ##
==========================================
+ Coverage 59.63% 64.57% +4.94%
==========================================
Files 29 28 -1
Lines 3793 3498 -295
==========================================
- Hits 2262 2259 -3
+ Misses 1531 1239 -292 ☔ View full report in Codecov by Sentry. |
* Preprocess now returns a list of paths to the temporary parquet files it created * Added type hint --------- Co-authored-by: middd2 <[email protected]>
|
@yusufuyanik1 would you mind giving this a review? Would like to merge it sometime soon |
yusufuyanik1
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had an anonymization script in the tools for a little bit, but these were not performant enough on any realistic and real loads, so it was time for an update. The configuration options here are much less, but it's much more efficient.
It utilizes a two-pass approach, whereby we first output all files to batched parquet files and then loop over all parquet files to generate one single output parquet file.
Many thanks to @danielm-dk for helping improve this part.