Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Quarto Render OS-Agnostic and Add Version Info to Health Check Logs #257

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

yusufuyanik1
Copy link
Collaborator

  • Simplified Quarto render subprocess to fix Windows failures and make it OS-agnostic.
  • Added version info to Health Check error logs for improved debugging.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.48%. Comparing base (1a5f258) to head (ac96f51).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
python/pdstools/adm/ADMDatamart.py 0.00% 7 Missing ⚠️
python/pdstools/utils/show_versions.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   64.31%   64.48%   +0.16%     
==========================================
  Files          28       28              
  Lines        3520     3522       +2     
==========================================
+ Hits         2264     2271       +7     
+ Misses       1256     1251       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@StijnKas StijnKas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments on this code itself: looks good! My only request is that we find a way to dynamically generate the dependencies and optional dependencies directly from the pyproject toml file, but it looks like that's not entirely trivial and probably deserves its own issue.

@yusufuyanik1 yusufuyanik1 merged commit 4fc2c26 into master Sep 9, 2024
16 checks passed
@StijnKas StijnKas deleted the Quarto-Fix branch October 8, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants