Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding (sub)titles, changing working dir to output dir, making report… #275

Merged
merged 7 commits into from
Nov 5, 2024

Conversation

operdeck
Copy link
Collaborator

@operdeck operdeck commented Nov 4, 2024

Optionally pass in title and subtitle to reports
Report tools used argument working_dir which really was the output_dir
Model report had hardcoded dependency on Issue column
Model report generation data file copying only for selected model id's

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 11.42857% with 31 lines in your changes missing coverage. Please review.

Project coverage is 58.68%. Comparing base (5a42b5c) to head (bbf096d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
python/pdstools/adm/Reports.py 0.00% 29 Missing ⚠️
python/pdstools/adm/ADMDatamart.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage   58.90%   58.68%   -0.23%     
==========================================
  Files          56       56              
  Lines        4877     4899      +22     
==========================================
+ Hits         2873     2875       +2     
- Misses       2004     2024      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@operdeck operdeck merged commit cd57738 into master Nov 5, 2024
3 of 10 checks passed
@StijnKas StijnKas deleted the report_interface_improvements branch January 6, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant