Add metric to monitor JFrog Access Federation validation endpoint #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor utils to clean up request and error handling * Readd warning for not found, move unmarshalling to after http error handling * Only handle unmarshalling error if HTTP status not successful
|
|
Refactored response and error handling in |
2 tasks
peimanja
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JFrog Access Federation can be setup for Artifactory to synchronize security related entities - such as users, roles, permissions, or tokens - between connected instances.
In this case establishing a circle of trust between these connected instances is required.
In order to monitor a valid Access Federation the
/access/api/v1/system/federation/validate_serverendpoint can be used. Calling this endpoint also requires providing a target server URL in the HTTP POST body.This pull request adds the functionality to monitor the above Access Federation circle of trust validation endpoint.
The new metric
access_federation_validis added to the optional metrics category, since the endpoint requires a few seconds to respond with the validation result. It requires a POST method, which has been added to utils.