Add support for external canonical URL #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? Because it wasn't possible to syndicate third party content or include your own blog posts already hosted elsewhere. This adds a new "Canonical:" or ":canonical:" metadata field so you can set canonical to an external URL.
There was a problem hiding this comment.
Hi @jorritfolmer,
Many thanks for your contribution! It's indeed a missing feature.
I let you some thoughts.
About the metadata name, I would go for external_canonical to avoid confusion with the generated internal canonical.
About the test comment, don't be afraid about the parametrize thought, I believe that the most important is to add a test at SEO enhancer level (before HTML generation).
If some points are not clear, don't hesitate to tell me!
MaevaBrunelles
requested changes
Apr 13, 2021
This was referenced Apr 13, 2021
Co-authored-by: Maëva Brunelles <[email protected]>
Co-authored-by: Maëva Brunelles <[email protected]>
Co-authored-by: Maëva Brunelles <[email protected]>
Co-authored-by: Maëva Brunelles <[email protected]>
MaevaBrunelles
approved these changes
Apr 14, 2021
|
Again many thanks for your contribution 💯 |
MaevaBrunelles
added a commit
that referenced
this pull request
Apr 14, 2021
Add support for external canonical URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? Because it wasn't possible to syndicate third party content or include your own blog posts already hosted elsewhere. This adds a new "Canonical:" or ":canonical:" metadata field so you can set canonical to an external URL.