Skip to content
This repository has been archived by the owner on Jan 8, 2019. It is now read-only.

Optionally create jobs from XML config instead of Template Job #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikeocool
Copy link
Contributor

We had kind of an annoying problem that popped up when we upgrade Jenkins a few months ago; every time we pushed anything to any branch on our github repo, the Jennifer template job would start building, and then immediately fail and trigger failure notifications on our various reporters, since ${pr_branch} isn't a real branch.

I poked around in jenkins, the git plugin, and the github plugin trying to figure out how to make this stop, and it seemed like it was sort of intentional. Basically, because the git plugin can't determine if there are any changes (since ${pr_branch} doesn't exist), it says 'GAH! I can't tell if anything has changed, do a build!'

It seemed like a nice way to avoid this issue all together would be to just get rid of the the template job altogether, and create jobs from a template jenkins project XML file that lived outside of Jenkins, and thus this pull request born.

@lra
Copy link
Member

lra commented Jan 30, 2015

@jamesob want to take a look at this?

@jamesob
Copy link
Contributor

jamesob commented Jan 30, 2015

sure. checking it out now. don't have a test environment set up though...

@jamesob
Copy link
Contributor

jamesob commented Jan 30, 2015

@mikeocool rad! this is a great change; thanks for sharing upstream.

I haven't tested this branch myself (no environment readily at hand), but nothing looks out of place after a few reads. @lra or @malford may want to test this on Percolate's environment.

It'd be really awesome to update README.md with information on how to use this new config option, and (potentially) a sample XML config file?

@lra
Copy link
Member

lra commented Jan 30, 2015

Cool,
@mikeocool feel like helping with this (README + sample XML)?
@malford can you test this out?

@mikeocool
Copy link
Contributor Author

Yeah, I'll definitely add a sample XML and update the README shortly.

@malford
Copy link
Contributor

malford commented Jan 31, 2015

@lra Sure, will test this out this week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants