changing default value of errorKind to sdk

percy · Oct 20, 2023 · 15b3d06 · 15b3d06
1 parent 5714d4a
commit 15b3d06
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/client/src/client.js b/packages/client/src/client.js
@@ -516,7 +516,7 @@ export class PercyClient {
     return comparison;
   }
 
-  async sendFailedEvents(buildId, { errorKind = 'cli', client = null, clientVersion = null, cliVersion = null, errorMessage = null } = {}) {
+  async sendFailedEvents(buildId, { errorKind = 'sdk', client = null, clientVersion = null, cliVersion = null, errorMessage = null } = {}) {
     validateId('build', buildId);
     this.log.debug('Sending FailedEvents');
     return this.post(`builds/${buildId}/failed-events`, {

diff --git a/packages/client/test/client.test.js b/packages/client/test/client.test.js
@@ -1341,7 +1341,7 @@ describe('PercyClient', () => {
       expect(api.requests['/builds/123/failed-events'][0].body).toEqual({
         data: {
           buildId: 123,
-          errorKind: 'cli',
+          errorKind: 'sdk',
           client: null,
           clientVersion: null,
           cliVersion: null,
@@ -1352,7 +1352,7 @@ describe('PercyClient', () => {
 
     it('should send failed event with default values', async () => {
       await expectAsync(client.sendFailedEvents(123, {
-        errorKind: 'sdk',
+        errorKind: 'cli',
         client: 'percy-appium-dotnet',
         clientVersion: '3.0.1',
         cliVersion: '1.27.3',
@@ -1364,7 +1364,7 @@ describe('PercyClient', () => {
       expect(api.requests['/builds/123/failed-events'][0].body).toEqual({
         data: {
           buildId: 123,
-          errorKind: 'sdk',
+          errorKind: 'cli',
           client: 'percy-appium-dotnet',
           clientVersion: '3.0.1',
           cliVersion: '1.27.3',