Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Fix percyCSS not getting applied when elements outside </body> #1415

Merged
merged 5 commits into from
Oct 30, 2023
Merged

✨ Fix percyCSS not getting applied when elements outside </body> #1415

merged 5 commits into from
Oct 30, 2023

Conversation

itsjwala
Copy link
Contributor

@itsjwala itsjwala commented Oct 27, 2023 •
edited
Loading

fixes #489

  • we've seen google ads/ custom JS running in test browser causing some DOM elements to be added outside </body>
  • This is fine visually since most browser's don't complain about it, though according to HTML spec its not correct.
  • We've logic where we regex replace last found </body> with percyCSS which used to fail due to these invalid tags.
  • We now provide an option reshuffleInvalidTags which moves this visually OK, but HTML spec wise not ok elements inside </body> tag.
    • Risks - CSS which are applied to BODY will now be applied to these tags - what we've also observed is these elements are generally ads iframes which are visible:hidden so this risk is acceptable.
  • This option can be used globally for percy snapshot command
    • And per-snapshot level for percy snapshot command and percySnapshot function.

itsjwala
itsjwala commented Oct 27, 2023
View reviewed changes
packages/core/src/config.js Outdated Show resolved Hide resolved
@itsjwala itsjwala marked this pull request as ready for review October 30, 2023 12:00
@itsjwala itsjwala requested a review from a team as a code owner October 30, 2023 12:00
@itsjwala itsjwala added the ✨ enhancement New feature or request label Oct 30, 2023
@itsjwala itsjwala merged commit c292189 into master Oct 30, 2023
35 of 36 checks passed
@itsjwala itsjwala deleted the percy_css_fix branch October 30, 2023 12:54
gfellerph referenced this pull request in swisspost/design-system Nov 6, 2023
@renovate @gfellerph
chore(deps): update all non-major dependencies (#2222)
ae65ed6 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@changesets/parse](https://togithub.com/changesets/changesets/tree/main#readme)
([source](https://togithub.com/changesets/changesets)) | [`0.1.0` ->
`0.3.16`](https://renovatebot.com/diffs/npm/@changesets%2fparse/0.1.0/0.3.16)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@changesets%2fparse/0.3.16?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@changesets%2fparse/0.3.16?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@changesets%2fparse/0.1.0/0.3.16?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@changesets%2fparse/0.1.0/0.3.16?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [@percy/cli](https://togithub.com/percy/cli) | [`1.27.3` ->
`1.27.4`](https://renovatebot.com/diffs/npm/@percy%2fcli/1.27.3/1.27.4)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@percy%2fcli/1.27.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@percy%2fcli/1.27.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@percy%2fcli/1.27.3/1.27.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@percy%2fcli/1.27.3/1.27.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[@stencil-community/eslint-plugin](https://togithub.com/stencil-community/stencil-eslint)
| [`0.5.0` ->
`0.6.0`](https://renovatebot.com/diffs/npm/@stencil-community%2feslint-plugin/0.5.0/0.6.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@stencil-community%2feslint-plugin/0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@stencil-community%2feslint-plugin/0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@stencil-community%2feslint-plugin/0.5.0/0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@stencil-community%2feslint-plugin/0.5.0/0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node)
([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) |
[`18.17.19` ->
`18.18.8`](https://renovatebot.com/diffs/npm/@types%2fnode/18.17.19/18.18.8)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2fnode/18.18.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2fnode/18.18.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2fnode/18.17.19/18.18.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2fnode/18.17.19/18.18.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[@types/react](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react)
([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) |
[`18.2.34` ->
`18.2.35`](https://renovatebot.com/diffs/npm/@types%2freact/18.2.34/18.2.35)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2freact/18.2.35?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2freact/18.2.35?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2freact/18.2.34/18.2.35?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2freact/18.2.34/18.2.35?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [eslint](https://eslint.org)
([source](https://togithub.com/eslint/eslint)) | [`8.52.0` ->
`8.53.0`](https://renovatebot.com/diffs/npm/eslint/8.52.0/8.53.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/eslint/8.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint/8.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint/8.52.0/8.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint/8.52.0/8.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[start-server-and-test](https://togithub.com/bahmutov/start-server-and-test)
| [`2.0.1` ->
`2.0.2`](https://renovatebot.com/diffs/npm/start-server-and-test/2.0.1/2.0.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/start-server-and-test/2.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/start-server-and-test/2.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/start-server-and-test/2.0.1/2.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/start-server-and-test/2.0.1/2.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [zone.js](https://togithub.com/angular/angular)
([changelog](https://togithub.com/angular/angular/blob/master/packages/zone.js/CHANGELOG.md))
| [`0.14.1` ->
`0.14.2`](https://renovatebot.com/diffs/npm/zone.js/0.14.1/0.14.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/zone.js/0.14.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/zone.js/0.14.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/zone.js/0.14.1/0.14.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/zone.js/0.14.1/0.14.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>changesets/changesets (@&#8203;changesets/parse)</summary>

###
[`v0.3.16`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.16)

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

##### Patch Changes

- Updated dependencies
\[[`521205d`](https://togithub.com/changesets/changesets/commit/521205dc8c70fe71b181bd3c4bb7c9c6d2e721d2)]:
-
[@&#8203;changesets/types](https://togithub.com/changesets/types)[@&#8203;5](https://togithub.com/5).2.1

###
[`v0.3.15`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.15)

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

##### Patch Changes

- Updated dependencies
\[[`8c08469`](https://togithub.com/changesets/changesets/commit/8c0846977597ddaf51aaeb35f1f0f9428bf8ba14)]:
-
[@&#8203;changesets/types](https://togithub.com/changesets/types)[@&#8203;5](https://togithub.com/5).2.0

###
[`v0.3.14`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.14)

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

##### Patch Changes

- Updated dependencies
\[[`dd9b76f`](https://togithub.com/changesets/changesets/commit/dd9b76f162a546ae8b412e0cb10277f971f3585e)]:
-
[@&#8203;changesets/types](https://togithub.com/changesets/types)[@&#8203;5](https://togithub.com/5).1.0

###
[`v0.3.13`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.13)

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

##### Patch Changes

- Updated dependencies
\[[`c87eba6`](https://togithub.com/changesets/changesets/commit/c87eba6f80a34563b7382f87472c29f6dafb546c)]:
-
[@&#8203;changesets/types](https://togithub.com/changesets/types)[@&#8203;5](https://togithub.com/5).0.0

###
[`v0.3.12`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.12)

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

##### Patch Changes

- Updated dependencies
\[[`27a5a82`](https://togithub.com/changesets/changesets/commit/27a5a82188914570d192162f9d045dfd082a3c15)]:
-
[@&#8203;changesets/types](https://togithub.com/changesets/types)[@&#8203;4](https://togithub.com/4).1.0

###
[`v0.3.11`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.11)

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

##### Patch Changes

- [#&#8203;740](https://togithub.com/changesets/changesets/pull/740)
[`957e39c`](https://togithub.com/changesets/changesets/commit/957e39c21549dd91e03faa5cd30e44e4c3d7331f)
Thanks [@&#8203;akphi](https://togithub.com/akphi)! - Fixed an issue
with failing to parse changesets containing a completely empty summary.

###
[`v0.3.10`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.10)

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

##### Patch Changes

- Updated dependencies
\[[`9a993ba`](https://togithub.com/atlassian/changesets/commit/9a993ba09629c1620d749432520470cec49d3a96)]:
-
[@&#8203;changesets/types](https://togithub.com/changesets/types)[@&#8203;4](https://togithub.com/4).0.2

###
[`v0.3.9`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.9)

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

##### Patch Changes

- Updated dependencies
\[[`e89e28a`](https://togithub.com/atlassian/changesets/commit/e89e28a05f5fa43307db73812a6bcd269b62ddee)]:
-
[@&#8203;changesets/types](https://togithub.com/changesets/types)[@&#8203;4](https://togithub.com/4).0.1

###
[`v0.3.8`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.8)

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

##### Patch Changes

- Updated dependencies
\[[`de2b4a5`](https://togithub.com/atlassian/changesets/commit/de2b4a5a7b244a37d94625bcb70ecde9dde5b612)]:
-
[@&#8203;changesets/types](https://togithub.com/changesets/types)[@&#8203;4](https://togithub.com/4).0.0

###
[`v0.3.7`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.7)

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

##### Patch Changes

-
[`5b6005e`](https://togithub.com/atlassian/changesets/commit/5b6005e0349a105b3d138fccdb22d13de8949862)
[#&#8203;462](https://togithub.com/atlassian/changesets/pull/462) Thanks
[@&#8203;Andarist](https://togithub.com/Andarist)! - Fixed an issue with
failing to parse changesets containing Windows newlines.

###
[`v0.3.6`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.6)

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

##### Patch Changes

- Updated dependencies
\[[`2b49d66`](https://togithub.com/atlassian/changesets/commit/2b49d668ecaa1333bc5c7c5be4648dda1b11528d)]:
-
[@&#8203;changesets/types](https://togithub.com/changesets/types)[@&#8203;3](https://togithub.com/3).0.0

###
[`v0.3.5`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.5)

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

##### Patch Changes

-
[`1706fb7`](https://togithub.com/atlassian/changesets/commit/1706fb751ecc2f5a792c42f467b2063078d58716)
[#&#8203;321](https://togithub.com/atlassian/changesets/pull/321) Thanks
[@&#8203;mitchellhamilton](https://togithub.com/mitchellhamilton)! - Fix
TypeScript declarations

- Updated dependencies
\[[`1706fb7`](https://togithub.com/atlassian/changesets/commit/1706fb751ecc2f5a792c42f467b2063078d58716)]:
-
[@&#8203;changesets/types](https://togithub.com/changesets/types)[@&#8203;2](https://togithub.com/2).0.1

###
[`v0.3.4`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.4)

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

##### Patch Changes

- Updated dependencies
\[[`011d57f`](https://togithub.com/atlassian/changesets/commit/011d57f1edf9e37f75a8bef4f918e72166af096e)]:
-
[@&#8203;changesets/types](https://togithub.com/changesets/types)[@&#8203;2](https://togithub.com/2).0.0

###
[`v0.3.3`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.3)

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

##### Patch Changes

-
[`04ddfd7`](https://togithub.com/atlassian/changesets/commit/04ddfd7c3acbfb84ef9c92873fe7f9dea1f5145c)
[#&#8203;305](https://togithub.com/atlassian/changesets/pull/305) Thanks
[@&#8203;Noviny](https://togithub.com/Noviny)! - Add link to changelog
in readme

- Updated dependencies
\[[`04ddfd7`](https://togithub.com/atlassian/changesets/commit/04ddfd7c3acbfb84ef9c92873fe7f9dea1f5145c),
[`e56928b`](https://togithub.com/atlassian/changesets/commit/e56928bbd6f9096def06ac37487bdbf28efec9d1)]:
-
[@&#8203;changesets/types](https://togithub.com/changesets/types)[@&#8203;1](https://togithub.com/1).0.1

###
[`v0.3.2`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.2)

##### Patch Changes

-
[`41e2e3d`](https://togithub.com/atlassian/changesets/commit/41e2e3dd1053ff2f35a1a07e60793c9099f26997)
[#&#8203;292](https://togithub.com/atlassian/changesets/pull/292) Thanks
[@&#8203;acheronfail](https://togithub.com/acheronfail)! - Fix
`repository` field in package.json

- Updated dependencies
\[[`41e2e3d`](https://togithub.com/atlassian/changesets/commit/41e2e3dd1053ff2f35a1a07e60793c9099f26997),
[`cc8c921`](https://togithub.com/atlassian/changesets/commit/cc8c92143d4c4b7cca8b9917dfc830a40b5cda20),
[`cc8c921`](https://togithub.com/atlassian/changesets/commit/cc8c92143d4c4b7cca8b9917dfc830a40b5cda20),
[`2363366`](https://togithub.com/atlassian/changesets/commit/2363366756d1b15bddf6d803911baccfca03cbdf)]:
-
[@&#8203;changesets/types](https://togithub.com/changesets/types)[@&#8203;1](https://togithub.com/1).0.0

###
[`v0.3.0`](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

###
[`v0.2.1`](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

###
[`v0.2.0`](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

###
[`v0.1.2`](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

[Compare
Source](https://togithub.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected])

</details>

<details>
<summary>percy/cli (@&#8203;percy/cli)</summary>

### [`v1.27.4`](https://togithub.com/percy/cli/releases/tag/v1.27.4)

[Compare
Source](https://togithub.com/percy/cli/compare/v1.27.3...v1.27.4)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

##### What's Changed

##### ✨ Enhancements

- Do not execute git commands when `PERCY_SKIP_GIT_CHECK` is set to True
by
[@&#8203;shantanuk-browserstack](https://togithub.com/shantanuk-browserstack)
in
[https://github.com/percy/cli/pull/1400](https://togithub.com/percy/cli/pull/1400)
- adding endpoint for sending failed event by
[@&#8203;prklm10](https://togithub.com/prklm10) in
[https://github.com/percy/cli/pull/1401](https://togithub.com/percy/cli/pull/1401)
- Introduce new config option enableLayout for enabling layout testing.
by [@&#8203;prklm10](https://togithub.com/prklm10) in
[https://github.com/percy/cli/pull/1378](https://togithub.com/percy/cli/pull/1378)
- Fix percyCSS not getting applied when elements outside `</body>` by
[@&#8203;itsjwala](https://togithub.com/itsjwala) in
[https://github.com/percy/cli/pull/1415](https://togithub.com/percy/cli/pull/1415)

##### 🐛 Bug Fixes

- Icons not loading when `noscript` tags are present. by
[@&#8203;shantanuk-browserstack](https://togithub.com/shantanuk-browserstack)
in
[https://github.com/percy/cli/pull/1404](https://togithub.com/percy/cli/pull/1404)
- Percy on Automate - Fixing percyScreenshotEnd response by
[@&#8203;rishigupta1599](https://togithub.com/rishigupta1599) in
[https://github.com/percy/cli/pull/1427](https://togithub.com/percy/cli/pull/1427)

##### 🏗 Maintenance

- Percy on Automate - Removing Redundant Calls for PoA by
[@&#8203;Amit3200](https://togithub.com/Amit3200) in
[https://github.com/percy/cli/pull/1413](https://togithub.com/percy/cli/pull/1413)

**Full Changelog**:
percy/cli@v1.27.3...v1.27.4

</details>

<details>
<summary>stencil-community/stencil-eslint
(@&#8203;stencil-community/eslint-plugin)</summary>

###
[`v0.6.0`](https://togithub.com/stencil-community/stencil-eslint/releases/tag/v0.6.0)

[Compare
Source](https://togithub.com/stencil-community/stencil-eslint/compare/v0.5.0...v0.6.0)

##### ❗  Breaking Changes

-   Node v12 and v14 deprecated.

##### What's Changed

- chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/stencil-community/stencil-eslint/pull/87](https://togithub.com/stencil-community/stencil-eslint/pull/87)
- chore(deps): bump tough-cookie from 4.1.2 to 4.1.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/stencil-community/stencil-eslint/pull/93](https://togithub.com/stencil-community/stencil-eslint/pull/93)
- chore(deps): bump word-wrap from 1.2.3 to 1.2.4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/stencil-community/stencil-eslint/pull/94](https://togithub.com/stencil-community/stencil-eslint/pull/94)
- Ban default true by [@&#8203;ysulyma](https://togithub.com/ysulyma) in
[https://github.com/stencil-community/stencil-eslint/pull/75](https://togithub.com/stencil-community/stencil-eslint/pull/75)
- chore(deps-dev): bump
[@&#8203;babel/traverse](https://togithub.com/babel/traverse) from
7.20.12 to 7.23.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/stencil-community/stencil-eslint/pull/98](https://togithub.com/stencil-community/stencil-eslint/pull/98)
- 🌟 chore: upgrade Eslint parser to 6.x by
[@&#8203;philippesic](https://togithub.com/philippesic) in
[https://github.com/stencil-community/stencil-eslint/pull/97](https://togithub.com/stencil-community/stencil-eslint/pull/97)
🌟

##### New Contributors

- [@&#8203;ysulyma](https://togithub.com/ysulyma) made their first
contribution in
[https://github.com/stencil-community/stencil-eslint/pull/75](https://togithub.com/stencil-community/stencil-eslint/pull/75)
- [@&#8203;philippesic](https://togithub.com/philippesic) made their
first contribution in
[https://github.com/stencil-community/stencil-eslint/pull/97](https://togithub.com/stencil-community/stencil-eslint/pull/97)

**Full Changelog**:
stencil-community/stencil-eslint@v0.5.0...v0.6.0

</details>

<details>
<summary>eslint/eslint (eslint)</summary>

### [`v8.53.0`](https://togithub.com/eslint/eslint/releases/tag/v8.53.0)

[Compare
Source](https://togithub.com/eslint/eslint/compare/v8.52.0...v8.53.0)

#### Features

-
[`528e1c0`](https://togithub.com/eslint/eslint/commit/528e1c00dc2aa8636e5b706c4270dc655cfa17e3)
feat: Deprecate formatting rules
([#&#8203;17696](https://togithub.com/eslint/eslint/issues/17696))
(Nicholas C. Zakas)
-
[`c0b11dd`](https://togithub.com/eslint/eslint/commit/c0b11ddb9f8aacc64c3933b9f278939aa7bea481)
feat: Add suggestions for no-prototype-builtins
([#&#8203;17677](https://togithub.com/eslint/eslint/issues/17677))
(Yonathan Randolph)

#### Bug Fixes

-
[`1ad6257`](https://togithub.com/eslint/eslint/commit/1ad6257744d63281235fcc33288394b1d69b34ce)
fix: ensure that exit code for fatal errors is not overwritten
([#&#8203;17683](https://togithub.com/eslint/eslint/issues/17683))
(Milos Djermanovic)
-
[`b329ea7`](https://togithub.com/eslint/eslint/commit/b329ea748dff45f11c7e218208244dc24fcb5c8f)
fix: add `;` after JSX nodes in `no-object-constructor` autofix
([#&#8203;17672](https://togithub.com/eslint/eslint/issues/17672))
(Francesco Trotta)

#### Documentation

-
[`ab8c60d`](https://togithub.com/eslint/eslint/commit/ab8c60d4f859cec787b5a12f7271b40e666235f5)
docs: change position of return to top button
([#&#8203;17688](https://togithub.com/eslint/eslint/issues/17688))
(Tanuj Kanti)
-
[`4fc44c0`](https://togithub.com/eslint/eslint/commit/4fc44c0b8c5dca466bffdfe01dfd80794d7762b7)
docs: update twitter icon to new X icon
([#&#8203;17687](https://togithub.com/eslint/eslint/issues/17687))
(Tanuj Kanti)
-
[`4164b2c`](https://togithub.com/eslint/eslint/commit/4164b2ceec89726b18ea0b0e34fab05735d55a09)
docs: Update README (GitHub Actions Bot)
-
[`8651895`](https://togithub.com/eslint/eslint/commit/8651895ca7ae15e13d74c8be67d9eebd63a7ce1f)
docs: Fix tabs in rule examples
([#&#8203;17653](https://togithub.com/eslint/eslint/issues/17653))
(Francesco Trotta)
-
[`3aec1c5`](https://togithub.com/eslint/eslint/commit/3aec1c55ba2c6d2833e1c0afe0a58f0cc6bbc0a4)
docs: explained rule fixers and suggestions
([#&#8203;17657](https://togithub.com/eslint/eslint/issues/17657)) (Josh
Goldberg ✨)

#### Chores

-
[`ba4d4d5`](https://togithub.com/eslint/eslint/commit/ba4d4d567a82554250dd8c7933322824e6a73944)
chore: remove metascraper
([#&#8203;17707](https://togithub.com/eslint/eslint/issues/17707))
(Milos Djermanovic)
-
[`0d07338`](https://togithub.com/eslint/eslint/commit/0d0733882944b4849d71a40723c251213698cef9)
chore: Update dependencies
([#&#8203;17706](https://togithub.com/eslint/eslint/issues/17706))
(Milos Djermanovic)
-
[`93256a3`](https://togithub.com/eslint/eslint/commit/93256a32e312f3f4e5c532762df71bdc06bded20)
chore: package.json update for
[@&#8203;eslint/js](https://togithub.com/eslint/js) release (ESLint
Jenkins)
-
[`485ec7d`](https://togithub.com/eslint/eslint/commit/485ec7d08ed2040c292f52bf9b9152f6c8ef4809)
test: fix ESLint tests for caching
([#&#8203;17699](https://togithub.com/eslint/eslint/issues/17699))
(Milos Djermanovic)
-
[`db06a7f`](https://togithub.com/eslint/eslint/commit/db06a7ff7992a74368f03d1f21beb00df0407021)
ci: bump actions/setup-node from 3 to 4
([#&#8203;17676](https://togithub.com/eslint/eslint/issues/17676))
(dependabot\[bot])
-
[`994596b`](https://togithub.com/eslint/eslint/commit/994596b07f5ff20a615a4be1ea03e5fd59cdb84b)
ci: run tests in Node.js 21
([#&#8203;17673](https://togithub.com/eslint/eslint/issues/17673))
(Francesco Trotta)

</details>

<details>
<summary>bahmutov/start-server-and-test
(start-server-and-test)</summary>

###
[`v2.0.2`](https://togithub.com/bahmutov/start-server-and-test/releases/tag/v2.0.2)

[Compare
Source](https://togithub.com/bahmutov/start-server-and-test/compare/v2.0.1...v2.0.2)

##### Bug Fixes

- **deps:** update dependency wait-on to v7.1.0
([efe7384](https://togithub.com/bahmutov/start-server-and-test/commit/efe7384f4e7befbd30b90a985fd518d86d3f3044))

</details>

<details>
<summary>angular/angular (zone.js)</summary>

###
[`v0.14.2`](https://togithub.com/angular/angular/blob/HEAD/packages/zone.js/CHANGELOG.md#0142-2023-11-03)

[Compare
Source](https://togithub.com/angular/angular/compare/zone.js-0.14.1...zone.js-0.14.2)

##### Bug Fixes

- **zone.js:** disable wrapping unhandled promise error by default
([6d7eb35](https://togithub.com/angular/angular/commit/6d7eb3548c5fc3aedb4a52ff2010141343748e90))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekend" in timezone
Europe/Zurich, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/swisspost/design-system).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Philipp Gfeller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shantanuk-browserstack shantanuk-browserstack shantanuk-browserstack approved these changes

@ninadbstack ninadbstack Awaiting requested review from ninadbstack ninadbstack is a code owner automatically assigned from percy/percy-product-reviewers

Assignees
No one assigned
Labels
✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Percy specific CSS fails if elements are present outside of <body>
3 participants
@itsjwala @ninadbstack @shantanuk-browserstack