Fix passthrough of enableJavascript option. (#24)

* Fix pass through of enableJavascript option. * Fix tests. * Fix variable name.
percy · Mar 21, 2017 · 74032a1 · 74032a1
1 parent 0914e01
commit 74032a1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/addon/snapshot.js b/addon/snapshot.js
@@ -61,6 +61,7 @@ export function percySnapshot(name, options) {
         content: getDoctype() + domCopy[0].outerHTML,
         widths: options.widths,
         breakpoints: options.breakpoints,
+        enableJavaScript: options.enableJavaScript,
       }),
       statusCode: {
         400: function(jqXHR) {

diff --git a/index.js b/index.js
@@ -313,6 +313,7 @@ module.exports = {
           {
             name: data.name,
             widths: widths,
+            enableJavaScript: data.enableJavaScript,
           }
         );
 

diff --git a/tests/acceptance/dummy-test.js b/tests/acceptance/dummy-test.js
@@ -35,3 +35,11 @@ test('name is autogenerated if given a Mocha test object', function(assert) {
   };
   percySnapshot(mochaTestDouble);
 });
+
+test('enableJavaScript option can pass through', function(assert) {
+  visit('/');
+  andThen(function() {
+    assert.equal(currentURL(), '/');
+  });
+  percySnapshot(assert, {enableJavaScript: true});
+});
-Original file line number
+Diff line change
@@ Expand Up / @@ -313,6 +313,7 @@ module.exports = { @@
               {
                 name: data.name,
                 widths: widths,
+                enableJavaScript: data.enableJavaScript,
               }
             );
@@ Expand Down @@