Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub authentication extra #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ewels
Copy link

@ewels ewels commented Feb 23, 2015

Hi there,

I just made a few changes to the GitHub authentication - mainly adding in the option to restrict access only to users who are members of a particular Organisation of choice. Also using some of the metadata returned from GitHub to make the user profile registration more complete.

Unfortunately I took the code from WordPress, used my GUI editor and then had to try to make a PR that wasn't all whitespace. It isn't perfect, hopefully it makes sense with ?w=1..

I'm happy with what we have working now, so feel free to take or leave as many of the changes as you like.

Phil

@ewels
Copy link
Author

ewels commented Feb 23, 2015

Yup, without whitespace looks better. Not sure why all of register.php is coming up as new.. Some kind of carriage return weirdness.

Phil

@ewels
Copy link
Author

ewels commented Feb 23, 2015

Just reduced the scope requested for the GitHub auth too - it was previously asking for full access, which was scaring people a little. Changing the scope from 'user' to '' (empty string) still seems to work fine, and is then read-only of public data only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant