Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retimePathWithKunz to Robot #505

Merged
merged 5 commits into from
Feb 17, 2019
Merged

Add retimePathWithKunz to Robot #505

merged 5 commits into from
Feb 17, 2019

Conversation

gilwoolee
Copy link
Contributor

@gilwoolee gilwoolee commented Feb 17, 2019

This PR adds retimeWithKunz method to Robot class and its derived classes. In the near future, we should replace this with a more general retimer (Issues #504, #477 ).


Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@gilwoolee gilwoolee requested a review from aditya-vk as a code owner February 17, 2019 02:09
@gilwoolee gilwoolee requested a review from brianhou as a code owner February 17, 2019 02:10
@gilwoolee gilwoolee added this to the Aikido 0.3.0 milestone Feb 17, 2019
@codecov
Copy link

codecov bot commented Feb 17, 2019

Codecov Report

Merging #505 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
- Coverage   77.66%   77.65%   -0.02%     
==========================================
  Files         262      262              
  Lines        6784     6784              
==========================================
- Hits         5269     5268       -1     
- Misses       1515     1516       +1
Impacted Files Coverage Δ
src/planner/ompl/CRRT.cpp 75.58% <0%> (-0.59%) ⬇️

brianhou
brianhou previously approved these changes Feb 17, 2019
@gilwoolee gilwoolee merged commit 71dfb5a into master Feb 17, 2019
@gilwoolee gilwoolee deleted the robot_use_kunz branch February 17, 2019 08:50
@gilwoolee gilwoolee mentioned this pull request Feb 17, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants