Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use KunzRetimer by default. #554

Closed
wants to merge 5 commits into from
Closed

Use KunzRetimer by default. #554

wants to merge 5 commits into from

Conversation

brianhou
Copy link
Contributor

@brianhou brianhou commented Oct 2, 2019

This is a temporary hack to make HERB demos work on master. We need to be able to properly dispatch to different postprocessors from librobot-level code.

I'm not sure whether ADA is using a similar hack, so please check. This is related to #477.


Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@aditya-vk
Copy link
Contributor

Are you looking to have this merged? I think we should solve this issue correctly to keep master clean and let this be on a working branch if it's for demos.

@brianhou
Copy link
Contributor Author

brianhou commented Oct 2, 2019

Agreed, although I don't think we even have an API designed to solve this issue properly yet.

@brianhou brianhou closed this Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants