Added defensive coding and warning - fixes #33 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,7 +62,13 @@ Write-Host "CodeCoverageFolder $CodeCoverageFolder" | |||
| Write-Host "ScriptBlock $ScriptBlock" | |||
|
|
|||
| Import-Module -Name (Join-Path $PSScriptRoot "HelperModule.psm1") -Force | |||
| Import-Pester -Version $TargetPesterVersion | |||
| If ($TargetPesterVersion -eq '4.99.99') { | |||
| Import-Pester -MaximumVersion $TargetPesterVersion | |||
There was a problem hiding this comment.
Import-Pester doesn't have a MaximumVersion parameter.
| @@ -47,6 +47,10 @@ if ($TargetPesterVersion -match '^5') { | |||
| Write-Host "##vso[task.logissue type=error]This version of the task does not support Pester V5, please use task version 10 or higher." | |||
| exit 1 | |||
| } | |||
| if ($TargetPesterVersion -match 'latest') { | |||
| Write-Host "##vso[task.logissue type=warning]Task version not properly set so defaulting to enforcing it to be the latest possible v4 that we will support in this version of the task - v4.99.99" | |||
| $TargetPesterVersion = '4.99.99' | |||
There was a problem hiding this comment.
Don't need this change to the target pester version, the import script handles "latest" fine.
|
Re-reading through this & the wider code base I don't think this change is actually needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR address?
Adds a bit of addition defensive coding
Is there a related Issue?
#33
Have you...