net8

.github/workflows/integrate.yml

@@ -16,7 +16,7 @@ jobs:
     - name: Setup .NET
       uses: actions/setup-dotnet@v3
       with:
-        dotnet-version: 7.0.x
+        dotnet-version: 8.0.x
     - name: Restore dependencies
       run: dotnet restore
     - name: Build

.github/workflows/release.yml

@@ -14,7 +14,7 @@ jobs:
     - name: Setup .NET
       uses: actions/setup-dotnet@v3
       with:
-        dotnet-version: 7.0.x
+        dotnet-version: 8.0.x
     - name: Extract version from tag
       id: get_version
       uses: battila7/get-version-action@v2

jsConnect.sln

@@ -1,14 +1,16 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio Version 16
-VisualStudioVersion = 16.0.29411.108
+# Visual Studio Version 17
+VisualStudioVersion = 17.9.34616.47
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{0EB0E003-5911-4A1F-A4FE-27A046C69D1A}"
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{06DB3DBE-1BB3-4D9F-9FD9-3AD7E9F07967}"
 	ProjectSection(SolutionItems) = preProject
 		.gitignore = .gitignore
+		.github\workflows\integrate.yml = .github\workflows\integrate.yml
 		README.md = README.md
+		.github\workflows\release.yml = .github\workflows\release.yml
 	EndProjectSection
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "jsConnect", "src\jsConnect\jsConnect.csproj", "{912C9673-A2BE-4841-80DE-4927B00D4AAB}"

src/jsConnect.Tests/jsConnect.Tests.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net7.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
   </PropertyGroup>
 
   <ItemGroup>

src/jsConnect/Controllers/AbstractControllerBase.cs

@@ -7,17 +7,10 @@
     /// <summary>
     /// Base controller containing default shared functionality.
     /// </summary>
-    public abstract class AbstractControllerBase<T> : Controller
+    public abstract class AbstractControllerBase<T>(IConfiguration configuration, ILogger<T> logger, ILoggerFactory loggerFactory) : Controller
     {
-        protected IConfiguration Configuration { get; set; }
-        protected ILogger<T> Logger { get; set; }
-        protected ILoggerFactory LoggerFactory { get; set; }
-
-        protected AbstractControllerBase(IConfiguration configuration, ILogger<T> logger, ILoggerFactory loggerFactory)
-        {
-            Configuration = configuration;
-            Logger = logger;
-            LoggerFactory = loggerFactory;
-        }
+        protected IConfiguration Configuration { get; set; } = configuration;
+        protected ILogger<T> Logger { get; set; } = logger;
+        protected ILoggerFactory LoggerFactory { get; set; } = loggerFactory;
     }
 }

src/jsConnect/Controllers/JsConnectController.cs

@@ -18,7 +18,7 @@
     /// Authentication endpoint implemented in accordance with http://docs.vanillaforums.com/help/sso/jsconnect/seamless/.
     /// </summary>
     [Route("[controller]")]
-    public class JsConnectController : AbstractControllerBase<JsConnectController>
+    public class JsConnectController(IConfiguration configuration, ILogger<JsConnectController> logger, ILoggerFactory loggerFactory, HashAlgorithm hashAlgorithm) : AbstractControllerBase<JsConnectController>(configuration, logger, loggerFactory)
     {
         #region "Configuration"
 
@@ -61,13 +61,7 @@
 
         #endregion
 
-        private HashAlgorithm HashAlgorithm { get; set; }
-
-
-        public JsConnectController(IConfiguration configuration, ILogger<JsConnectController> logger, ILoggerFactory loggerFactory, HashAlgorithm hashAlgorithm) : base(configuration, logger, loggerFactory)
-        {
-            HashAlgorithm = hashAlgorithm;
-        }
+        private HashAlgorithm HashAlgorithm { get; set; } = hashAlgorithm;
 
         /// <summary>
         /// Returns details of a currently signed-in user, if any.

src/jsConnect/Extensions.cs

@@ -8,7 +8,7 @@
 
 namespace jsConnect
 {
 	public static class Extensions
 	{
 		/// <summary>
 		/// Converts given object to JSON with padding.
@@ -22,11 +22,8 @@
 			{
 				throw new ArgumentNullException(nameof(callback), "Callback parameter must be initialized.");
 			}
-			if (o == null)
-			{
-				throw new ArgumentNullException(nameof(o));
-			}
-			var settings = new JsonSerializerSettings
+            ArgumentNullException.ThrowIfNull(o);
+            var settings = new JsonSerializerSettings
 			{
 				NullValueHandling = NullValueHandling.Ignore
 			};
@@ -50,22 +47,16 @@
 		/// <param name="buff">Array to convert.</param>
 		public static string ToHexString(this byte[] buff)
 		{
-			if (buff == null)
-			{
-				throw new ArgumentNullException(nameof(buff));
-			}
-			return buff.Aggregate("", (current, t) => current + t.ToString("x2"));
+            ArgumentNullException.ThrowIfNull(buff);
+            return buff.Aggregate("", (current, t) => current + t.ToString("x2"));
 		}
 
 		/// <summary>
 		/// Encodes URL according to RFC1738 (http://www.ietf.org/rfc/rfc1738.txt). In addition, it encodes $-_.+!*'() characters.
 		/// </summary>
 		public static string UrlEncode(this string s)
 		{
-			if (s == null)
-			{
-				throw new ArgumentNullException(nameof(s));
-			}
+            ArgumentNullException.ThrowIfNull(s);
             static string me(Match m) => m.ToString().ToUpper();
 
             string result = WebUtility.UrlEncode(s);
@@ -81,16 +72,13 @@
 		}
 
 		/// <summary>
 		/// Retrieves an object from a given <see cref="Dictionary{TKey,TValue}"/>. Covers situations where the <see cref="key"/> doesn't exist.
 		/// </summary>
 		/// <returns>Returns value if the given key exists. Otherwise, returns a default value of <see cref="L"/>.</returns>
 		public static L GetValue<T, L>(this Dictionary<T, L> dic, T key)
 		{
-			if (dic == null)
-			{
-				throw new ArgumentNullException(nameof(dic));
-			}
-			if (dic.TryGetValue(key, out L value))
+            ArgumentNullException.ThrowIfNull(dic);
+            if (dic.TryGetValue(key, out L value))
 			{
 				return value;
 			}

src/jsConnect/JsConnectException.cs

@@ -2,10 +2,13 @@
 
 namespace jsConnect
 {
-	/// <summary>
-	/// Exception object containing parameters expected by Vanilla Forums.
-	/// </summary>
-	public class JsConnectException : Exception
+    /// <summary>
+    /// Exception object containing parameters expected by Vanilla Forums.
+    /// </summary>
+    /// <remarks>
+    /// Default constructor.
+    /// </remarks>
+    public class JsConnectException(string error, string message) : Exception(message)
 	{
 		#region "Preconfigured error codes"
 
@@ -19,19 +22,11 @@
 		/// </summary>
 		public const string ERROR_INVALID_CLIENT = "invalid_client";
 
-		#endregion
+        #endregion
 
-		/// <summary>
-		/// Short error code.
-		/// </summary>
-		public string Error { get; set; }
-
-		/// <summary>
-		/// Default constructor.
-		/// </summary>
-		public JsConnectException(string error, string message) : base(message)
-		{
-			Error = error;
-		}
-	}
+        /// <summary>
+        /// Short error code.
+        /// </summary>
+        public string Error { get; set; } = error;
+    }
 }

src/jsConnect/Models/JsConnectResponseModel.cs

@@ -4,26 +4,26 @@
 
 namespace jsConnect.Models
 {
 	public class JsConnectResponseModel
 	{
 		private string _error = null;
 		private string _message = null;
 
 		[JsonProperty("client_id")]
 		public string ClientId
 		{
 			get; set;
 		}
 
 		[JsonProperty("signature")]
 		public string Signature
 		{
 			get; set;
 		}
 
 
 		[JsonProperty("error")]
 		public string Error
 		{
 			get { return _error; }
 			set
@@ -48,7 +48,7 @@
 		#region "User Data"
 
 		[JsonIgnore]
-		private readonly Dictionary<string, string> UserData = new();
+		private readonly Dictionary<string, string> UserData = [];
 
 		[JsonProperty("uniqueid")]
 		public string UniqueId

src/jsConnect/jsConnect.csproj

@@ -3,7 +3,7 @@
   <PropertyGroup>
     <Description>Vanilla Forums' jsConnect for ASP.NET Core MVC</Description>
     <Authors>Petr Svihlik;Jan Lenoch</Authors>
-    <TargetFramework>net7.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
     <AssemblyName>jsConnect</AssemblyName>
     <PackageId>jsConnectAspNetCoreMvc</PackageId>
     <PackageLicenseUrl>https://github.com/petrsvihlik/jsConnectAspNetCoreMvc/blob/master/LICENSE</PackageLicenseUrl>