fix: fix intermittent test issues

petyosi · Nov 14, 2022 · a6c021d · a6c021d
1 parent 729498a
commit a6c021d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/e2e/grid-scroll-seek-placeholder.test.ts b/e2e/grid-scroll-seek-placeholder.test.ts
@@ -15,7 +15,7 @@ test.describe('list with scroll seek placeholders', () => {
       }, 10)
     })
 
-    await page.waitForTimeout(200)
+    await page.waitForSelector('#test-root div[aria-label=placeholder]')
 
     const [width, height, containerPaddingTop, text, color] = await page.evaluate(() => {
       const container = document.querySelector('#test-root > div > div:first-child > div') as HTMLElement

diff --git a/e2e/scroll-seek-placeholder.test.ts b/e2e/scroll-seek-placeholder.test.ts
@@ -15,7 +15,7 @@ test.describe('list with scroll seek placeholders', () => {
       }, 10)
     })
 
-    await page.waitForTimeout(200)
+    await page.waitForSelector('#test-root div[aria-label=placeholder]')
 
     const color = await page.evaluate(() => {
       const stickyItem = document.querySelector('#test-root > div > div:first-child > div > div') as HTMLElement

diff --git a/examples/grid-scroll-seek-placeholder.tsx b/examples/grid-scroll-seek-placeholder.tsx
@@ -32,7 +32,11 @@ export default function App() {
       components={{
         Item: ItemContainer,
         List: ListContainer,
-        ScrollSeekPlaceholder: ({ index, width, height }) => <div style={{ height, width, color: 'red' }}>Placeholder {index}</div>,
+        ScrollSeekPlaceholder: ({ index, width, height }) => (
+          <div aria-label="placeholder" style={{ height, width, color: 'red' }}>
+            Placeholder {index}
+          </div>
+        ),
       }}
     />
   )

diff --git a/examples/scroll-seek-placeholder.tsx b/examples/scroll-seek-placeholder.tsx
@@ -13,7 +13,11 @@ export default function App() {
         exit: (velocity) => Math.abs(velocity) < 30,
       }}
       components={{
-        ScrollSeekPlaceholder: ({ height, index }) => <div style={{ height, color: 'red' }}>Placeholder {index}</div>,
+        ScrollSeekPlaceholder: ({ height, index }) => (
+          <div aria-label="placeholder" style={{ height, color: 'red' }}>
+            Placeholder {index}
+          </div>
+        ),
       }}
     />
   )