Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for oauth2 profile arrays, empty email error log #8392

Merged
merged 8 commits into from
Jan 28, 2025
Merged

add support for oauth2 profile arrays, empty email error log #8392

merged 8 commits into from
Jan 28, 2025

Conversation

hauserkristof
Copy link
Contributor

Details are covered in #8391

TLDR; enable handling of JSON array return types on OAUTH2_USERINFO_ENDPOINTs, like github's user/emails for supporting private email addresses.

@hauserkristof hauserkristof mentioned this pull request Jan 22, 2025
Closed
khushboovashi
khushboovashi requested changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@khushboovashi khushboovashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the PEP 8 issue. You can check the

web/pgadmin/authenticate/oauth2.py Outdated Show resolved Hide resolved
@hauserkristof
Copy link
Contributor Author

Please fix the PEP 8 issue. You can check the

Please run the pipelines again to check

thanks!

@khushboovashi khushboovashi merged commit 1e00611 into pgadmin-org:master Jan 28, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushboovashi khushboovashi Awaiting requested review from khushboovashi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hauserkristof @khushboovashi