Sort indices for SparseVector

pgvector · Jun 25, 2024 · 38923c0 · 38923c0
1 parent 1a0f175
commit 38923c0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/SparseVector.php b/src/SparseVector.php
@@ -34,9 +34,10 @@ public static function fromDense($value)
 
     public static function fromMap($map, $dimensions)
     {
+        // okay to update in-place since parameter is not a reference
+        ksort($map);
         $indices = [];
         $values = [];
-        // no need to sort since binary format is not supported
         foreach ($map as $i => $v) {
             $fv = floatval($v);
             if ($fv != 0) {

diff --git a/tests/SparseVectorTest.php b/tests/SparseVectorTest.php
@@ -16,8 +16,11 @@ public function testFromDense()
 
     public function testFromMap()
     {
-        $embedding = SparseVector::fromMap([2 => 2, 4 => 3, 0 => 1, 3 => 0], 6);
+        $map = [2 => 2, 4 => 3, 0 => 1, 3 => 0];
+        $embedding = SparseVector::fromMap($map, 6);
         $this->assertEquals([1, 0, 2, 0, 3, 0], $embedding->toArray());
+        $this->assertEquals([0, 2, 4], $embedding->indices());
+        $this->assertEquals([2, 4, 0, 3], array_keys($map));
     }
 
     public function testFromString()