Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity testing for hAMRonization #40

Merged
merged 22 commits into from
Nov 12, 2020
Merged

Add sanity testing for hAMRonization #40

merged 22 commits into from
Nov 12, 2020

Conversation

cimendes
Copy link
Member

This PR adds, through the pytest package, sanity testing for the parsers implemented so far. This adressed issues #18 and #19.

To run the sanity tests, simple invoke pytest in the test directory. The sanity tests are implemented in the test_sanity.py file, which are automatically detected by pytest. More information is available in the README.md file inside the test directory.
The single-entry files used in the sanity testing are stored in test/dummy. I'm not sure if this is the most appropriate name/location. Raw outputs are available at test/data and contain real reports.

Main issues to be discussed:

This still to be adressed:

Additionally, unit tests to each of the parsers functions could be implemented.

@cimendes cimendes requested a review from fmaguire November 11, 2020 13:46
@cimendes cimendes self-assigned this Nov 11, 2020
Update to latest version of master
@cimendes cimendes marked this pull request as draft November 11, 2020 14:24
@cimendes cimendes marked this pull request as ready for review November 11, 2020 14:25
@fmaguire fmaguire merged commit 4a747af into master Nov 12, 2020
@cimendes cimendes mentioned this pull request Nov 16, 2020
@fmaguire fmaguire deleted the validation branch June 2, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants