Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version number in manifest #33

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Fix version number in manifest #33

merged 1 commit into from
Sep 3, 2024

Conversation

sgsutcliffe
Copy link
Contributor

In the 1.0.4 patch release the version listed in the nextflow.config manifest section was not updated.

@sgsutcliffe sgsutcliffe requested a review from apetkau September 3, 2024 18:22
Copy link

github-actions bot commented Sep 3, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f370b90

+| ✅ 134 tests passed       |+
#| ❔  26 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.0.4
  • schema_lint - Schema $id should be https://raw.githubusercontent.com/phac-nml/iridanextexample/master/nextflow_schema.json
    Found https://raw.githubusercontent.com/phac-nml/iridanextexample/main/nextflow_schema.json
  • nfcore_yml - nf-core version not set in .nf-core.yml

❔ Tests ignored:

  • files_exist - File is ignored: assets/nf-core-iridanextexample_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-iridanextexample_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-iridanextexample_logo_dark.png
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: lib/Utils.groovy
  • files_exist - File is ignored: lib/WorkflowMain.groovy
  • files_exist - File is ignored: lib/NfcoreTemplate.groovy
  • files_exist - File is ignored: lib/WorkflowIridanextexample.groovy
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-iridanextexample_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-iridanextexample_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-iridanextexample_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/iridanextexample/iridanextexample/.github/workflows/awstest.yml
  • actions_awsfulltest - actions_awsfulltest
  • pipeline_name_conventions - pipeline_name_conventions

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-03 18:23:24

Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@sgsutcliffe sgsutcliffe merged commit daa7f17 into main Sep 3, 2024
11 checks passed
@sgsutcliffe sgsutcliffe deleted the dev branch September 3, 2024 20:38
@apetkau apetkau restored the dev branch October 18, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants