Added new feature that allows to leave all variables undeclared if option selected in dialog #17482
+45
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion selected in dialog
|
Now I think that the CodeReparator should be a presenter and that it should pass via the application to raise menu. MorphicUIManager will break. |
…dialog-could-propose-to-leave-all-undeclared-as-undefined
|
In a future step yes! I fixed the merge conflict |
|
This breaks a lot of tests sadly |
jecisc
added
the
Status: Need more work
|
The compiler architecture sucks. It should not raise UI or talk to UI elements. |
And moreover, it does not add new tests for the new behavior. I'm sorry but It's difficult to accept new features without tests. Also, whenever doing UI changes, please add screenshots of the new features in the PR. |
AlexisCnockaert
deleted the
17460-Feature-Request-Undefined-variable-dialog-could-propose-to-leave-all-undeclared-as-undefined
branch
AlexisCnockaert
restored the
17460-Feature-Request-Undefined-variable-dialog-could-propose-to-leave-all-undeclared-as-undefined
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17460