-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch: RedoingClosePresenter, Deleted everything so SpClosedWindowListPresenter can be independant #17676
Branch: RedoingClosePresenter, Deleted everything so SpClosedWindowListPresenter can be independant #17676
Conversation
…esenter can be independant
This issue has either a default title or empty body. We would appreciate it if you could provide more information. Note: I am not a very intelligent bot, I can only react to new comments. Please add a comment for me if you update the body or title. |
But Alexis you still refer to Sp* so we have a dependency from Morphic to Presenter. |
sorry yes there is an announcement I forgot |
We do have announcements yes. Some browser were missing it but I fixed some cases when I implemented my POC. Here is the code I used: self currentWorld announcer
when: WindowClosed
do: [ :ann | cache at: DateAndTime now put: ann window ]
for: self |
The problem is it will add a new window on the list everytime, for example if I want to close for real my hidden window, a WindowClosed announcement will be announced too, adding again the window to the list. |
What you can maybe do is to prevent the announcement for the second time. self currentWorld announcer prevent: WindowClosed during: [ window close ] |
I wonder if the memory leak I have in the my image does not come from the uncloseable logic so we should really pay attention and be picky. |
…works with announcements
now SystemWindow has nothing linked with the presenter