Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate the separate types for user space and kernel addresses #116

Merged
merged 3 commits into from
Jan 26, 2025

Conversation

phaubertin
Copy link
Owner

@phaubertin phaubertin commented Jan 26, 2025

There are currently two types in the kernel for physical addresses:

  • kern_paddr_t for addresses to memory used by the kernel.
  • user_paddr_t for addresses to memory used by the kernel.

The original rationale was that the kernel only uses memory under the 4GB, so kern_paddr_t could be 32 bits instead of 64 bits. While this is true, the kernel might still need to map things above this mark like ACPI table.

This PR replaces both types with a single paddr_t type.

@phaubertin phaubertin marked this pull request as ready for review January 26, 2025 01:46
@phaubertin phaubertin merged commit 4b6ea58 into main Jan 26, 2025
2 checks passed
@phaubertin phaubertin deleted the chore_single_paddr_type branch January 26, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant