GitHub actions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that we can introduce the dependency on Vite assets to have been build before running phpunit, so we can ensure that the GitHub actions workflow takes this into account.
So that we don't have to have the dev server running, or have built assets previously, before running tests.
philbates35
force-pushed
the
github-actions
branch
6 times, most recently
from
c2fdbf6 to
45de9ec
Compare
There is definitely room for improvement here (e.g. script duplication across jobs, passing artifacts from one job to the next, caching dependencies etc) but this is a simple starting point.
philbates35
force-pushed
the
github-actions
branch
2 times, most recently
from
45ffc23 to
245d7e1
Compare
philbates35
added a commit
that referenced
this pull request
Feb 9, 2024
See: * https://phpstan.org/blog/what-is-bleeding-edge * https://backendtea.com/post/use-phpstan-bleeding-edge/ Fix the following three new highlighted issues at the same time: [philbates@fedora laravel-starter]$ docker-compose exec php composer run phpstan -- --memory-limit=512M > phpstan --ansi '--memory-limit=512M' Note: Using configuration file /app/phpstan.neon.dist. 50/50 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Line app/Models/User.php ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 35 PHPDoc type array<int, string> of property App\Models\User::$hidden is not the same as PHPDoc type list<string> of overridden property Illuminate\Database\Eloquent\Model::$hidden. 💡 You can fix 3rd party PHPDoc types with stub files: 💡 https://phpstan.org/user-guide/stub-files ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- ------ ------------------------------------------------------------------------------------------- Line app/Providers/RouteServiceProvider.php ------ ------------------------------------------------------------------------------------------- 33 Using nullsafe property access "?->id" on left side of ?? is unnecessary. Use -> instead. ------ ------------------------------------------------------------------------------------------- ------ ----------------------------------------------------------------------------------------------------------------- Line bootstrap/app.php ------ ----------------------------------------------------------------------------------------------------------------- 17 Parameter #1 $basePath of class Illuminate\Foundation\Application constructor expects string|null, mixed given. ------ -----------------------------------------------------------------------------------------------------------------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is definitely room for improvement here (e.g. script duplication across jobs, passing artifacts from one job to the next, caching dependencies etc) but this is a simple starting point.