Replaced uniqid with a uuid function. #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some research on the
uniqid();
function, and the chance for a conflict seems a bit high. I've also came across this post discussing the issues with it.I can't take credit for the UUID code in my pull request. I found this answer when researching a PHP function to generate UUID's.
Another option is to use the WordPress
wp_generate_uuid4
function, but the code from Stack Overflow doesn't seem as reliant on WordPress, though since this is a package for ACF, that probably doesn't matter.Hope you pull in my changes or consider using a different function to generate these IDs!