Skip to content

Commit

Permalink
Use RouteMiddleware instead of PathBasedRoutingMiddleware
Browse files Browse the repository at this point in the history
Per changes for final v3 release.
  • Loading branch information
weierophinney committed Mar 27, 2018
1 parent 1caca9d commit c7c8f65
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/OAuth2CallbackMiddlewareFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
use Zend\Expressive\Authentication\AuthenticationMiddleware;
use Zend\Expressive\Container\ApplicationFactory;
use Zend\Expressive\Router\Middleware\DispatchMiddleware;
use Zend\Expressive\Router\Middleware\PathBasedRoutingMiddleware;
use Zend\Expressive\Router\Middleware\RouteMiddleware;
use Zend\Expressive\Session\SessionMiddleware;

/**
Expand Down Expand Up @@ -84,7 +84,7 @@ public function __invoke(ContainerInterface $container) : MiddlewareInterface
$pipeline->get($path, Debug\DebugProviderMiddleware::class);
}

$pipeline->pipe(PathBasedRoutingMiddleware::class);
$pipeline->pipe(RouteMiddleware::class);
$pipeline->pipe(DispatchMiddleware::class);

return $pipeline;
Expand Down
14 changes: 11 additions & 3 deletions test/OAuth2CallbackMiddlewareFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,17 @@
use Phly\Expressive\OAuth2ClientAuthentication\Debug\DebugProviderMiddleware;
use Phly\Expressive\OAuth2ClientAuthentication\OAuth2CallbackMiddlewareFactory;
use PHPUnit\Framework\TestCase;
use Prophecy\Argument;
use Prophecy\Prophecy\ObjectProphecy;
use Psr\Container\ContainerInterface;
use Psr\Http\Server\MiddlewareInterface;
use ReflectionProperty;
use Zend\Expressive\Application;
use Zend\Expressive\MiddlewareContainer;
use Zend\Expressive\MiddlewareFactory;
use Zend\Expressive\Router\Middleware\PathBasedRoutingMiddleware;
use Zend\Expressive\Router\Middleware\RouteMiddleware;
use Zend\Expressive\Router\Route;
use Zend\Expressive\Router\RouteCollector;
use Zend\Expressive\Router\RouterInterface;
use Zend\HttpHandlerRunner\RequestHandlerRunner;
use Zend\Stratigility\MiddlewarePipe;
Expand All @@ -39,14 +42,19 @@ public function setUp()

$runner = $this->prophesize(RequestHandlerRunner::class);
$router = $this->prophesize(RouterInterface::class);
$routeMiddleware = new PathBasedRoutingMiddleware($router->reveal());
$router->addRoute(Argument::type(Route::class))->shouldBeCalled();

$routeMiddleware = new RouteMiddleware($router->reveal());

$routes = new RouteCollector($router->reveal());

$this->pipeline = new MiddlewarePipe();

$middlewareFactory = new MiddlewareFactory(new MiddlewareContainer($this->container->reveal()));
$this->container->get(MiddlewareFactory::class)->willReturn($middlewareFactory);
$this->container->get(\Zend\Expressive\ApplicationPipeline::class)->willReturn($this->pipeline);
$this->container->get(PathBasedRoutingMiddleware::class)->willReturn($routeMiddleware);
$this->container->get(RouteCollector::class)->willReturn($routes);
$this->container->get(RouteMiddleware::class)->willReturn($routeMiddleware);
$this->container->get(RequestHandlerRunner::class)->will([$runner, 'reveal']);

$this->factory = new OAuth2CallbackMiddlewareFactory();
Expand Down

0 comments on commit c7c8f65

Please sign in to comment.