Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hal/imxrt117x: fix Fractional PLL configuration and enable PLL1 #372

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

hal/imxrt117x: fix Fractional PLL configuration and enable PLL1 #372

wants to merge 2 commits into from

Conversation

julianuziemblo
Copy link
Contributor

@julianuziemblo julianuziemblo commented Dec 9, 2024 •
edited
Loading

Description

Fractional PLLs are configured throught registers in VDDSOC2, which are accessible through Analog IP interface.
ENET module in iMX RT1170 EVK/EVKB needs PLL1 to work.

Motivation and Context

This change is needed to properly initialize, set bypass and deinitialize Fractional PLLs (SYS_PLL1, PLL_AUDIO, PLL_VIDEO).

For this to work and the tests to pass, phoenix-rtos/phoenix-rtos-project#1248 is needed

related: phoenix-rtos/phoenix-rtos-project#1251

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: armv7m7-imxrt117x-evk.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets:

Special treatment

@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt117x-evkb branch from b03bad6 to 17ca693 Compare December 9, 2024 15:37
@julianuziemblo julianuziemblo mentioned this pull request Dec 9, 2024
Open
14 tasks
agkaminski
agkaminski previously approved these changes Dec 10, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

Unit Test Results

7 958 tests   7 416 ✅  40m 23s ⏱️
  470 suites    542 💤
    1 files        0 ❌

Results for commit 1727871.

♻️ This comment has been updated with latest results.

nalajcie
nalajcie requested changes Dec 10, 2024
View reviewed changes
Copy link
Member

@nalajcie nalajcie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't want new compilation warnings! Please think how it can be avoided (and keeping the implementation).

Not sure if we would like to unanimously enable 1GHz PLL on every project, maybe it should be configurable by board_config.h?

@nalajcie
Copy link
Member

No, I don't want new compilation warnings! Please think how it can be avoided (and keeping the implementation).

IMHO we could define functions with __attribute__((unused)) - the most readable solution for me :)

@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt117x-evkb branch from 17ca693 to 6b1acb1 Compare December 10, 2024 15:38
@julianuziemblo julianuziemblo mentioned this pull request Dec 10, 2024
Closed
14 tasks
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt117x-evkb branch from 6b1acb1 to 0b4f165 Compare December 10, 2024 15:45
@julianuziemblo
hal/imxrt117x: fix PLL set bypass and PLL1 deinit
daf9956 
Fractional PLLs (SYS_PLL1, PLL_AUDIO and PLL_VIDEO) are
configured through VDDSOC2 registers, which are accessed
via the Analog IP interface.

JIRA: RTOS-963
@julianuziemblo
hal/imxrt117x: add function to enable PLL1 and its dividers
1727871 
PLL1 and its dividers can be enabled in board_config.h

JIRA: RTOS-963
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt117x-evkb branch from 0b4f165 to 1727871 Compare February 3, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agkaminski agkaminski agkaminski approved these changes

@Darchiv Darchiv Awaiting requested review from Darchiv

@nalajcie nalajcie Awaiting requested review from nalajcie

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianuziemblo @nalajcie @agkaminski