Skip to content

Commit

Permalink
Merge pull request #415 from phst-randomizer/tox-pyinstaller
Browse files Browse the repository at this point in the history
Run pyinstaller build in isolated env using `tox`
  • Loading branch information
mike8699 authored Nov 5, 2023
2 parents 05c693f + ff18845 commit 64d3806
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/build-test-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -483,11 +483,8 @@ jobs:
- name: Upgrade `pip` and install `wheel`
run: python -m pip install --upgrade pip wheel

- name: Install randomizer dependencies
run: pip install .

- name: Install pyinstaller
run: pip install -U pyinstaller
- name: Install tox
run: pip install tox

- name: Download base patches
uses: actions/download-artifact@v3
Expand All @@ -498,7 +495,7 @@ jobs:
mv ./**/*.bps base/out
- name: Build randomizer executable
run: pyinstaller ph_rando.spec
run: tox -e build

- name: Get current commit hash
id: commit-hash
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ types = [
"types-setuptools~=68.2.0.0",
"types-tqdm~=4.66.0.1",
]
pyinstaller = ["pyinstaller==6.1.0"]

[project.scripts]
ph_rando = "ph_rando.ui.main:main"
Expand Down
6 changes: 6 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,11 @@ extras =
commands =
pytest --numprocesses auto {posargs} tests/desmume

[testenv:build]
extras =
pyinstaller
commands =
pyinstaller ph_rando.spec

[pytest]
addopts = --strict-markers --showlocals --verbose

0 comments on commit 64d3806

Please sign in to comment.