Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nbFile overload for file embedding #219

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

PhilippMDoerner
Copy link
Contributor

This also adds an example.

Note: On my machine locally it was impossible to fully run nimble docs, even after running nimble docsDeps.
Because it doesn't find the happyx custom block:
/home/philipp/dev/nimib/docsrc/interactivity.nim(281, 5) Error: undeclared identifier: 'nbHappyxCode'.

This is caused by the when moduleAvailable(happyx) check failing because
/home/philipp/.nimble/pkgs2/happyx-3.0.0-09a3bb3a93ddca05b973235465eb1f2c6414d5b8/happyx/spa/tag.nim(216, 8) Error: undeclared identifier: 're2'.

I assume that's a happyx problem.

This also adds an example
Copy link
Owner

@pietroppeter pietroppeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor detail, the rest looks good!

src/nimib.nim Outdated Show resolved Hide resolved
Co-authored-by: Pietro Peterlongo <[email protected]>
@pietroppeter
Copy link
Owner

for ref on this, see the discussion we had here, in particular the linked comment: pietroppeter/nimibook#85 (comment)

will wait for preview to build and check

will also look to open an issue about the happy problem for documents

thanks for working on this!

@PhilippMDoerner
Copy link
Contributor Author

Checks passed!

Regarding the issue, appears I read your comment too late, I already opened HapticX/happyx#170 😅

@Ethosa
Copy link

Ethosa commented Oct 29, 2023

/home/philipp/.nimble/pkgs2/happyx-3.0.0-09a3bb3a93ddca05b973235465eb1f2c6414d5b8/happyx/spa/tag.nim(216, 8) Error: undeclared identifier: 're2'.

@PhilippMDoerner please delete all versions of regex package and install #head version. This should help.
image

@pietroppeter
Copy link
Owner

yep, indeed the preview works fine! (if you look at the last check you will see there is a netlify preview and clicking on details let you look at built docs):
image

regarding happyx, actually happy that you went and opened the issue, I thought it was an issue with nimib.

thanks and have a great day (or likely great night)!

@pietroppeter pietroppeter merged commit e256687 into pietroppeter:main Oct 29, 2023
5 checks passed
@pietroppeter
Copy link
Owner

btw, note that LICENSE is bizarrely highlighted (I guess by highlight.js) by mistake...

@PhilippMDoerner PhilippMDoerner deleted the add-file-embedding branch October 29, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants